Skip to content

feat(identity): persist dual-proof write after inspect - #192

Closed
cursor[bot] wants to merge 20 commits into
mainfrom
cursor/bc-bad99cc6-066a-491f-87e9-92754e857e23-7468
Closed

feat(identity): persist dual-proof write after inspect#192
cursor[bot] wants to merge 20 commits into
mainfrom
cursor/bc-bad99cc6-066a-491f-87e9-92754e857e23-7468

Conversation

@cursor

@cursor cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Why

PR #178 inspects projection drift and reconciles the unique enforcer after restore. A hosted adapter still had no command that refuses a new dual-proof write while that inspect reports drift, then authorizes both current proofs, persists the history, and recovers the same product-owned participant from a later valid Keyverse account.

TDD

RED restore_drift_refuses_dual_proof_write_until_operator_reconciles plants a stale current row for ended keyverse_subject_write, proves persist_authorized_account_link returns CurrentProjectionDrift without mutating the in-memory participant, then after reconcile the later participant_identity_write_epsilon binds and recovers. GREEN inspects first, authorizes both proofs, persists, and recovers.

Scope

Out of scope

Operator next action

After restore, run inspect_identity_link_current_projection_drift. If it reports drift, run reconcile_identity_link_current_projections before calling persist_authorized_account_link. Prefer this head over #178 and #160. Do not merge those. Do not merge this PR until exact-head checks and independent last-push approval are satisfied. Never self-approve.

Open in Web View Automation 

cursoragent and others added 20 commits August 16, 2026 15:25
A buyer who links an anonymous assessment to a Keyverse account must
still see that link after process restart. Persist assessment_participant
plus append-only link and link-end evidence, reload through the domain
lifecycle, and fail closed on conflicting replay or a subject already
bound to another participant.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Keep TRACEABILITY, ADR-0020, ERD, and as-built schema pointing at the
opened persist/reload vehicle instead of an unnamed Active PR.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
The Active PR #114 naming commit stored an empty ADR-0020. Restore the
accepted decision, including the #114 persistence status and APA 7
references, so identity-link governance is not silently deleted.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Apply each identity link and then its matching ends in one transaction so a complete in-memory unlink+relink aggregate survives restart. Cover one-shot persist, exact replay, and subject reuse after unlink.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Add a tenant-scoped current-subject lookup so a returning Keyverse login can find the same product-owned participant after the anonymous session token is gone. Ended or replaced subjects stay unfindable until they are current again.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Renumber the identity-link migration so it does not collide with #113 scoring-job health indexes on 0021. Name Active PR #124 as the merge candidate over #114.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Remove the accidentally committed build tree and ignore /target so later local verification cannot leak compiler outputs into the identity-link successor.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
A missing current_participant_identity_link row no longer hides a
returning Keyverse login or lets another participant bind the same
issuer-scoped subject. Lookup and uniqueness now read append-only
link rows that have no matching end.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Name the Active PR vehicle as the successor of #124 so TRACEABILITY,
ADR-0020, and the as-built schema do not treat projection-only lookup
as the landing contract.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Add a composite foreign key so a link-end or current projection cannot
point at another participant's identity-link row. Name Active PR #133
as the landing vehicle over #124 and #114.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Exact replay of the same identity-link history now reconciles the derived
current projection so operator repair cannot hide a returning login behind
a missing unique enforcer or leave a stale row after unlink. Name Active
PR #133 in TRACEABILITY instead of superseded #124.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
After dump restore the unique enforcer can be missing or stale even
though unterminated history is intact. Rebuild every current row from
that history, fail closed on two unterminated holders of the same
subject, and prefer this successor over #147.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Keep TRACEABILITY, ADR-0020, ERD, and as-built schema pointing at the
opened restore-reconcile vehicle instead of an unnamed successor of #147.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Add a read-only inspect so operators can see missing or stale unique-enforcer rows after dump restore, fail closed on two unterminated links for one participant, and run reconcile only when that inspect reports drift.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Point TRACEABILITY, ADR-0020, ERD, and the as-built schema at the inspect-and-reconcile landing so writers do not reopen #158 or #133.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Fold the #173 buyer path onto the #169 inspect line: a stale current row for an ended Keyverse subject must keep that account occupied until inspect reports drift and restore reconcile rebuilds the unique enforcer. After that path, a later participant can bind the freed subject. Lock ADR-0020 Implementation status to the TRACEABILITY landing PR.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Point TRACEABILITY, ADR-0020, AS_BUILT, and ERD at #178 so concurrent writers do not treat #173 or #169 as the identity-link landing vehicle.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Hosted adapters authorize both current proofs only after restore
inspect is clean, persist the append-only history, and recover the
same participant from a later valid account. Prefer this write-path
head over #160.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Record the dual-proof write successor as the identity-link landing
so concurrent writers do not treat #178 or #160 as the persist vehicle.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of #192 (b8f43a8)

Prefer this inspect-then-write head over #183, #178, #166, and #160. Do not merge those predecessors.

What holds

  • persist_authorized_account_link inspects current-projection drift before dual-proof authorization, so a stale unique enforcer cannot accept a new first-link and the in-memory participant stays unlinked on refuse.
  • Recover still resolves from unterminated history while inspect reports drift. That is the intended returning-login path, not a missing inspect gate.
  • Realistic PostgreSQL coverage includes restart recover, expired/unused proofs, subject-already-bound, and restore_drift_refuses_dual_proof_write_until_operator_reconciles.
  • HTTP and live Keyverse verification stay out of this slice.

Merge gates that are still open

  • Draft.
  • Required checks were still queued at review time; queued is not acceptance.
  • Independent last-push approval is still required. Do not self-approve.

Buyer gap this head does not close

A returning account can recover after restart, but cannot disconnect. The authorized unlink successor on cursor/bc-08d3bd7b-4151-4d01-992f-2afd21638d37-6992 adds that command. Prefer that successor once it is opened; keep #192 unmerged as a predecessor.

Open in Web View Automation 

Sent by Cursor Automation: Fix Issues

cursor Bot pushed a commit that referenced this pull request Aug 16, 2026
Prefer #202 over #192 and earlier identity-link predecessors.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Copy link
Copy Markdown
Contributor

Closing as superseded by PR #202. #202 explicitly carries this inspect → dual-proof persist/recover path and adds the missing buyer lifecycle operation: an authorized unlink that appends the link end, clears returning-account recovery, and permits later relink without rewriting historical participant identity. Its current scope says to prefer #202 over #192 and not merge #192 separately. Continue exact-head review on #202 or its later successor.

@seonghobae seonghobae closed this Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants