fix(result): publish snapshots only after scoring has begun - #189
Draft
cursor[bot] wants to merge 5 commits into
Draft
fix(result): publish snapshots only after scoring has begun#189cursor[bot] wants to merge 5 commits into
cursor[bot] wants to merge 5 commits into
Conversation
Processing consumption rows now require claim_deadline_at after #81. Seed the wall-clock deadline and prove binary restore preserves it.
A Created session can still receive an immutable result on the owner-binding constructor. Prove that only Scoring or Scored sessions may publish. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
ResultSnapshot::new now fails closed unless the assessment session is Scoring or Scored, so a Created, Active, Completed, Released, or terminal session cannot receive a personal score. Success-path fixtures drive the session through Activate, Complete, and BeginScoring. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ResultSnapshot::newnow binds participant, session, and instrument-version provenance to the authoritativeAssessmentSession(#97). That constructor still accepted aCreatedsession, so a personal score could be published for a session that never activated, completed, or began scoring.Scope
ScoringorScored;Created,Active,Paused,Completed,Released,Expired,Cancelled, andInvalidated;Out of scope
claim_deadline_atdocumentation remains test(recovery): preserve inbox claim deadline evidence #177.Prefer this head over #97 for the combined owner-binding + scoring-state gate. Do not treat this as a substitute for #157 or #177.