Route remaining LLM jobs through contextual-orchestrator - #403
Merged
Conversation
Point hourly product development at the same gateway contract as review and remove sequential NIM model-candidate failover from Noema. Provider keys stay in the orchestrator KV. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (47)
📝 WalkthroughWalkthroughNoema의 리뷰 및 시간별 제품 개발 흐름을 Changes게이트웨이 계약과 검증
리뷰어와 시간별 실행 흐름
CI base 검증
데이터룸 증빙
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant Workflow
participant VerifyCLI
participant Gateway
participant OpenCode
Workflow->>VerifyCLI: 게이트웨이 URL과 모델 검증
VerifyCLI->>Gateway: 인증 없는 /healthz 요청
Gateway-->>VerifyCLI: 서비스 식별 응답
VerifyCLI->>OpenCode: 단일 gateway 설정 기록
Workflow->>OpenCode: 전용 API 키로 세션 실행
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Point leftover reviewer FallbackModel settings at a fail-closed error and cover the shared orchestrator gateway CLI entry so Noema no longer tries the next model itself. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
cursor
Bot
changed the title
Keep the orchestrator gateway contract at 100% coverage after the entrypoint extraction. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
The decorator was sitting on the complete-bundle test and broke collection. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Expose the secret-free gateway contract so ContextualWisdomLab/naruon can run Noema as a judgments-and-decisions agent without copying OpenCode or provider keys. naruon wiring stays a separate repository PR. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Preserve the protected-main workflow-registry disablement implementation and coverage while retaining the orchestrator gateway cutover; merge coverage ownership without dropping either production script.
This was referenced Aug 17, 2026
seonghobae
marked this pull request as ready for review
August 17, 2026 11:21
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noema routes remaining model-backed jobs through one bounded
contextual-orchestratorgateway contract rather than provider/model fallback lists in this repository.Current exact state
cursor/orchestrator-llm-gateway-c28f85626a736a9b7a6691ff505ed5bbbae631b6fe198fa25716df43d915aaa1ce3c7a0470d765cf50ca32024140060: queued / non-passing until terminal success.32024140064: queued / non-passing until terminal success.32024140096: queued / non-passing until terminal success.Predecessor-head success does not transfer to this head. Mergeability alone is not merge readiness.
What this PR changes
/v1contextual-orchestrator gateway and/healthzidentity boundary.Exact application-CI RCA and repairs
The predecessor exact head
c8b18ffbfb55343d59947a23960fbff5bc6ad920failed application CI32020525532becauseparseOrchestratorGatewayUrl("https://./v1")did not reject a hostname that became empty after trailing-dot canonicalization. The existing regressiontest/orchestrator-gateway-trailing-dot-host.test.tswas already RED on that exact head.Commit
c419f18029e44746094b4c4917ae97a4e8890728applies the smallest production fix: after lowercasing and removing trailing dots, an empty canonical hostname now fails with the existing absolute-HTTPS-URL error contract. On that head all 1,895 tests passed, including the formerly failing trailing-dot-host regression, but the global 100% coverage gate remained RED at 99.97% statements/lines and 99.96% branches. Exact coverage output isolated the only uncovered production line toscripts/lib/orchestrator-gateway.mjs:375, the oversizedarrayBuffer()fallback boundary.Commit
85626a736a9b7a6691ff505ed5bbbae631b6fe19adds a realistic non-streaming response regression with no trustedContent-Length: a 65,537-byte fallback body must fail closed after one materialization. This covers the exact residual branch without lowering thresholds or adding V8 exclusions.The latest exact-head CI/reviewer/Security runs are still queued, so this is a GREEN candidate, not verified completion. If application CI remains red, inspect the exact new failure before any further source/test mutation.
Dependency boundary
ContextualWisdomLab/contextual-orchestratorremains a read-only source dependency to this Noema writer. This PR consumes its published gateway identity/routing contract without moving provider-selection authority or provider credentials into Noema.Merge boundary
Do not mark Ready or merge until the unchanged exact head has terminal-success application CI plus every applicable live central Security/review/governance gate and zero valid unresolved findings. No gate is weakened or bypassed.
Summary by CodeRabbit
새 기능
개선
문서