Skip to content

fix(coverage): measure operational trace helpers - #332

Closed
seonghobae wants to merge 3 commits into
mainfrom
fix/coverage-trace-helpers-2d9d4e
Closed

fix(coverage): measure operational trace helpers#332
seonghobae wants to merge 3 commits into
mainfrom
fix/coverage-trace-helpers-2d9d4e

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Purpose

Advance #84 with a bounded test-first slice on protected main 2d9d4e26a81d043a1985fc2244efb2a311fcf1d0. This slice removes jsonResponse, trustedTraceHeader, and traceIdFromRequest from the first broad V8 exclusion while leaving the remaining Region A helpers and the credential/OIDC/GitHub App Region B unchanged.

RED -> GREEN evidence

  • RED head: 9dd731588168e776bd07295385db15f5ffbbbefe added a deterministic source contract rejecting broad exclusion of the three named helpers. Protected source violated that contract.
  • Behavior-test head: 4e17cdda73a54019d2849a3ffd9d5fb96a047e19 added real Request/Response regressions proving valid x-request-id propagation and invalid-request-id fallback to a valid x-correlation-id.
  • Current GREEN source head: 30dd9bc0e61a6f2304298cdb3ba9fff5e95e0fa0. Its only production diff moves the existing /* v8 ignore start */ boundary from before jsonResponse to immediately before safeHash; runtime behavior is otherwise unchanged.

The source contract is now satisfied on the exact current head. Full repository acceptance remains fail closed until fresh exact-head ci, reviewer-ci, and protected-base central Security Scan complete successfully and configured owned-production statements/branches/functions/lines remain exactly 100% with zero valid unresolved findings. At the last refetch these runs were queued, which is non-passing.

Safety boundary

Keep Draft while any exact-head required evidence is pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor-only, status-only, model-only, or rate-limited.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e8c49d34-0028-4d28-ae0a-bd44b1afbdec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae changed the title test(coverage): expose operational trace helpers to V8 fix(coverage): measure operational trace helpers Aug 14, 2026
@seonghobae seonghobae closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant