fix(coverage): measure operational trace helpers - #332
Closed
seonghobae wants to merge 3 commits into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Advance #84 with a bounded test-first slice on protected
main2d9d4e26a81d043a1985fc2244efb2a311fcf1d0. This slice removesjsonResponse,trustedTraceHeader, andtraceIdFromRequestfrom the first broad V8 exclusion while leaving the remaining Region A helpers and the credential/OIDC/GitHub App Region B unchanged.RED -> GREEN evidence
9dd731588168e776bd07295385db15f5ffbbbefeadded a deterministic source contract rejecting broad exclusion of the three named helpers. Protected source violated that contract.4e17cdda73a54019d2849a3ffd9d5fb96a047e19added realRequest/Responseregressions proving validx-request-idpropagation and invalid-request-id fallback to a validx-correlation-id.30dd9bc0e61a6f2304298cdb3ba9fff5e95e0fa0. Its only production diff moves the existing/* v8 ignore start */boundary from beforejsonResponseto immediately beforesafeHash; runtime behavior is otherwise unchanged.The source contract is now satisfied on the exact current head. Full repository acceptance remains fail closed until fresh exact-head
ci,reviewer-ci, and protected-base centralSecurity Scancomplete successfully and configured owned-production statements/branches/functions/lines remain exactly 100% with zero valid unresolved findings. At the last refetch these runs were queued, which is non-passing.Safety boundary
1d8b9a3fafc07f0df6e79a286f141d21e22bc1f9and has not moved since 2026-08-10; this slice changes only private operational coverage instrumentation plus focused tests. Freeze this lane if docs(api): inventory and document non-conflicting TypeScript API #86 moves.Keep Draft while any exact-head required evidence is pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor-only, status-only, model-only, or rate-limited.