Skip to content

security(replay): claim verified OIDC use before GitHub token creation #81

Description

@seonghobae

Completed protected-main invariant

The replay-before-token-mint defect is now protected-main truth.

  • protected main: 933471b954512710bb9635f18f45fe8f323adcff;
  • merged implementation: PR fix(security): claim verified OIDC replay before token mint #270, exact reviewed head 0e7bd32d0fbc7e91972d5feb73bd8fe73799b16a, merge commit 933471b954512710bb9635f18f45fe8f323adcff;
  • protected-main CI run 31787748349 / verify job 94727390148: terminal success on that exact protected SHA, including exact checkout, pinned package-manager verification, install, and full release verify;
  • protected source contains test/replay-before-token-mint.test.ts with a real RS256-signed OIDC fixture proving a verified replay returns 401 ERR_AUTH_REPLAY and produces zero POSTs to /app/installations/{id}/access_tokens;
  • the accepted-first-use regression requires exact ordering replay-claim → installation-lookup → token-mint:POST and the protected worker exposes the successful path as single-use replay protection.

The implemented ordering is now:

distributed rate limit → bounded workflow prefilter → cryptographic OIDC verification → target-repository authorization → atomic distributed replay claim → GitHub App installation-token mint → response.

Unverified payload claims do not reserve replay state. Missing replay binding/verified claims and replay-service failure remain fail-closed before credential delivery.

Canonical architecture/documentation convergence remains tracked by #71/#82/#84 and does not reopen this already-integrated product/security defect. No release, deployment, outbound-license, production KPI, or acquisition-readiness claim is implied by closing this issue.

Related: #270, #273, #71, #82, #84.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions