feat(diagnostics): add collaborative writing-guidance parity - #281
Draft
seonghobae wants to merge 26 commits into
Draft
feat(diagnostics): add collaborative writing-guidance parity#281seonghobae wants to merge 26 commits into
seonghobae wants to merge 26 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack authority
This Draft is Task 7 collaborative parity for the writing-diagnostics stack, on current #280 (
feat/writing-diagnostics-editor-actions).feat/writing-diagnostics-editor-actions@84baeda29e0da8b45a635c22cce28c4790b54983;feat/writing-diagnostics-collaboration@e4d1f56391865c44eabacdcb9fac607327921972;84baeda...;48ed047556e2ce0dcf34aecb94f326dcaaa104f8is an ancestor of the current head and therefore predecessor evidence only.The previous body named
a76919b...as the current #280 base and48ed047...as the current head. Those claims are superseded by live PR metadata and ancestry.Included behavior
This lane provides collaborative parity for already-verified host writing diagnostics: the same host-supplied diagnostic props, accessible guidance panel and imperative Focus / Apply / Ignore / Dismiss / Explain methods as standalone
CwlEditor; exact strong-revision verification before local Apply; plain-text replacement through an ordinary collaborative ProseMirror/Yjs transaction; immediate stale-all invalidation for local or remote document changes; two-client convergence and collaborative undo/redo; no fabricated action event on a remote client that only receives Yjs updates; read-only Apply prevention; stable editor identity/latest callback ownership; race rejection when remote updates arrive during verification or pending Apply digest; awareness privacy; and host ownership of the suppliedY.Doclifecycle.Inkspan performs no semantic inference and calls no LLM/model provider/network reviewer/database/persistence service. Diagnostic identifiers, titles, explanations, replacements, revisions, provenance and authored text are not written into awareness state.
TDD lineage
Historical RED→GREEN proof through predecessor
48ed047...established focused collaborative behavior, full production suite, exact 100% owned-production coverage, package/demo builds and fail-closed Reactactwarning handling. Those results remain implementation lineage but do not transfer as exact-current-head gate evidence after the current non-destructive stack synchronization.Current evidence
A fresh exact-current-head workflow lookup for
e4d1f56391865c44eabacdcb9fac607327921972returns no PR workflow runs. Current required CI/Security/SAST/coverage/package/browser/accessibility evidence is therefore absent/non-passing. Predecessor checks/reviews must not transfer. #299 remains the existing stacked-PR trigger-gap owner path, but absent evidence is still non-passing.Keep this PR Draft and stacked behind #280. Before any lifecycle transition, verify ancestry against the then-current #280 exact head, remove temporary branch-specific TDD workflow material if still present, reacquire every applicable exact-current-head required workflow, resolve only addressed threads, obtain the qualifying independent non-author approval required by live ruleset
18156473, and respect #118's protected release boundary. #282 owns the framework-independent package subpath; this branch does not publish npm, create a tag/release or claim host semantic/model authority.