fix: default discovery must reuse chat egress (not #658) - #678
Closed
cursor[bot] wants to merge 3 commits into
Closed
fix: default discovery must reuse chat egress (not #658)#678cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Unique slice vs PR #642: discover models when a KV credential is present (static fallback only on GET /v1/models failure), retain original_list_price when billed rates are promotional 0, select one min-cost/max-performance worker instead of walking a next-agent list, and expose GET /v1/models for Noema and other first-class /v1 consumers. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Issue #86 honesty: PriceBook.compute_cost returns None on a missing row instead of 0.0. Explicit billed 0 stays actual free-to-caller; original_list_price stays the hypothetical list beside it. Selection and cheapest_upstream skip unknown instead of treating it as free. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Reject loopback, private, link-local, and reserved addresses before a KV Bearer is attached, and refuse 3xx so the credential is never replayed. Partial price rows that omit billed rates stay unknown. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
seonghobae
marked this pull request as ready for review
August 16, 2026 17:06
seonghobae
enabled auto-merge (squash)
August 16, 2026 17:06
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
auto-merge was automatically disabled
August 16, 2026 18:23
Pull request was closed
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unique slice (do not merge as a duplicate)
Protected main is still
6841b719. This is the landing vehicle for #658 (default discovery,original_list_price, choose-once min-cost,GET /v1/models, Noema) plus the chat egress boundary that #658 is missing.--from-env, flag-gated--discover-models, OpenCode sidecar, 429 hopGET /v1/modelsDo not merge #658 in parallel. Do not merge #642/#661 onto the same main tip as this PR (two catalog HTTP stacks).
What changed after #658
9274f64provider_egress.provider_base_url_rejectionused by chat and catalog.allow_insecureis ignored on the production fetch path.unknown, not promotional-free.Tests (secret-free)
Local: catalog, price, security, and reliability scripts passed on this head.
Papers
APA 7th claim boundary:
docs/doctoring/priced-selection.md(adds OWASP Foundation, 2021, SSRF cheat sheet). Requirement owner: issue #86.Next action
Review this head. If the egress tests and choose-once / cost-honesty contracts hold, merge this PR and leave #658 unmerged.