feat(api): opt-in CORS allowlist for browser clients - #136
Conversation
CORS is disabled by default. Exact --cors-allow-origin entries enable Access-Control-Allow-Origin, credentials for non-*, and OPTIONS preflight.
|
Warning Review limit reached
Next review available in: 21 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| origin = (self.headers.get("origin") or "").strip() | ||
| allowed = security.cors_origin_allowed(origin) | ||
| if allowed: | ||
| self.send_header("access-control-allow-origin", allowed) |
| - feat/cors-allowlist | ||
|
|
||
| permissions: | ||
| contents: write |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head9717128aa437714ce39de5aae0592be2f2c0d7e4. -
Head SHA:
9717128aa437714ce39de5aae0592be2f2c0d7e4 -
Workflow run: 32014582802
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: one-shot-pr136-cors-header-hardening.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: one-shot-pr136-cors-header-hardening.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (4 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (4 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Docs: architecture.md"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs: architecture.md"]
R3 --> V3["docs review"]
Evidence --> S4["Test: test_cors_allowlist.py"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test: test_cors_allowlist.py"]
R4 --> V4["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: one-shot-pr136-cors-header-hardening.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: one-shot-pr136-cors-header-hardening.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (4 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (4 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Docs: architecture.md"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs: architecture.md"]
R3 --> V3["docs review"]
Evidence --> S4["Test: test_cors_allowlist.py"]
S4 --> I4["regression suite"]
I4 --> R4["Review risk: Test: test_cors_allowlist.py"]
R4 --> V4["targeted test run"]
|
2 participants
Summary
Buyer browser SDKs need CORS without opening the gateway by default.
SecurityConfig.cors_allow_originsexact-match allowlist (CLI--cors-allow-origin)OPTIONSpreflight with methods/headers max-ageAccess-Control-Allow-Origin+ credentials for non-*Test plan
pytest tests/test_cors_allowlist.py(3 passed)Auto-merge armed; still needs independent APPROVE (#123).