fix(security): healthz/readyz, request framing, trace authority on main - #129
fix(security): healthz/readyz, request framing, trace authority on main#129seonghobae wants to merge 5 commits into
Conversation
Split unauthenticated /healthz liveness (status+service only) from admin-authenticated /readyz inventory (closes #118). Fail-closed Content-Length validation rejects negative/non-decimal/missing/chunked framing before socket reads (closes #119). Orchestration traces require verified authority beyond inference; JSON boolean coercion is strict (closes #117).
|
Warning Review limit reached
Next review available in: 38 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…open Match the org gate's nosemgrep style used on green product heads so the main-base healthz/framing PR is not blocked by audited false positives.
Match #129 suppressions so main-base PRs pass the required Semgrep gate: bound DB-API placeholders in cost_ledger (not string-concat user SQL), intentional verify_tls=False SSL opt-out, and validated provider urllib.
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headb4f37ff9fdf924aa75095ab1e77c58474ca8d4de. -
Head SHA:
b4f37ff9fdf924aa75095ab1e77c58474ca8d4de -
Workflow run: 31702379909
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (5 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (5 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: architecture.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: architecture.md"]
R2 --> V2["docs review"]
Evidence --> S3["Test (4 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (4 files)"]
R3 --> V3["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (5 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (5 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: architecture.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: architecture.md"]
R2 --> V2["docs review"]
Evidence --> S3["Test (4 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (4 files)"]
R3 --> V3["targeted test run"]
|
Summary
Main-base security gap fill for buyer-visible operability and least privilege:
GET /healthzreturns only process liveness (status+service). Inventory (agent counts, batch backends, usage counts) moves to admin-authenticatedGET /readyz.Content-Lengthvalidation rejects missing, negative, non-decimal, oversized, and non-identity Transfer-Encoding before socket body reads.include_orchestration_trace.Tests
tests/test_healthz.pytests/test_request_framing.pytests/test_trace_authority.pyRelation to #121
#121 tracks the same issues on a parallel tip. This PR is a main-base delivery of the same security contract so protected
maincan land the gap independently of the approval-deadlocked stack.Doctoring
CHANGELOG.mdSecurity sectiondocs/architecture.mdhealth/readiness noteCloses #117
Closes #118
Closes #119