Skip to content

fix(security): healthz/readyz, request framing, trace authority on main - #129

Open
seonghobae wants to merge 5 commits into
mainfrom
fix/healthz-framing-trace-main
Open

fix(security): healthz/readyz, request framing, trace authority on main#129
seonghobae wants to merge 5 commits into
mainfrom
fix/healthz-framing-trace-main

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

Main-base security gap fill for buyer-visible operability and least privilege:

Tests

  • tests/test_healthz.py
  • tests/test_request_framing.py
  • tests/test_trace_authority.py
  • Related security suite subset (23 passed locally)

Relation to #121

#121 tracks the same issues on a parallel tip. This PR is a main-base delivery of the same security contract so protected main can land the gap independently of the approval-deadlocked stack.

Doctoring

  • CHANGELOG.md Security section
  • docs/architecture.md health/readiness note

Closes #117
Closes #118
Closes #119

Split unauthenticated /healthz liveness (status+service only) from
admin-authenticated /readyz inventory (closes #118). Fail-closed
Content-Length validation rejects negative/non-decimal/missing/chunked
framing before socket reads (closes #119). Orchestration traces require
verified authority beyond inference; JSON boolean coercion is strict
(closes #117).
Main-base buyer security: unauthenticated liveness is minimal; readiness
inventory requires admin auth; Content-Length framing is fail-closed;
orchestration traces are not granted to inference-only callers.
Closes #117 #118 #119.
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1aa838d9-8961-45dd-9e15-d6e6c117ee01

📥 Commits

Reviewing files that changed from the base of the PR and between 6841b71 and b4f37ff.

📒 Files selected for processing (10)
  • CHANGELOG.md
  • README.md
  • contextual_orchestrator/cost_ledger.py
  • contextual_orchestrator/orchestrator.py
  • contextual_orchestrator/server.py
  • docs/architecture.md
  • tests/test_cost_review_server.py
  • tests/test_healthz.py
  • tests/test_request_framing.py
  • tests/test_trace_authority.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae enabled auto-merge (squash) August 12, 2026 22:14
…open

Match the org gate's nosemgrep style used on green product heads so the
main-base healthz/framing PR is not blocked by audited false positives.
seonghobae added a commit that referenced this pull request Aug 12, 2026
Match #129 suppressions so main-base PRs pass the required Semgrep gate:
bound DB-API placeholders in cost_ledger (not string-concat user SQL),
intentional verify_tls=False SSL opt-out, and validated provider urllib.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head b4f37ff9fdf924aa75095ab1e77c58474ca8d4de.

  • Head SHA: b4f37ff9fdf924aa75095ab1e77c58474ca8d4de

  • Workflow run: 31702379909

  • Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (5 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (5 files)"]
  R1 --> V1["required checks"]
  Evidence --> S2["Docs: architecture.md"]
  S2 --> I2["operator or user guidance"]
  I2 --> R2["Review risk: Docs: architecture.md"]
  R2 --> V2["docs review"]
  Evidence --> S3["Test (4 files)"]
  S3 --> I3["regression suite"]
  I3 --> R3["Review risk: Test (4 files)"]
  R3 --> V3["targeted test run"]
Loading

@opencode-agent

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: b4f37ff9fdf924aa75095ab1e77c58474ca8d4de
  • Workflow run: 31702379909
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head b4f37ff9fdf924aa75095ab1e77c58474ca8d4de.

  • Head SHA: b4f37ff9fdf924aa75095ab1e77c58474ca8d4de

  • Workflow run: 31702379909

  • Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (5 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (5 files)"]
  R1 --> V1["required checks"]
  Evidence --> S2["Docs: architecture.md"]
  S2 --> I2["operator or user guidance"]
  I2 --> R2["Review risk: Docs: architecture.md"]
  R2 --> V2["docs review"]
  Evidence --> S3["Test (4 files)"]
  S3 --> I3["regression suite"]
  I3 --> R3["Review risk: Test (4 files)"]
  R3 --> V3["targeted test run"]
Loading

@opencode-agent
opencode-agent Bot disabled auto-merge August 13, 2026 18:20
@seonghobae
seonghobae enabled auto-merge (squash) August 13, 2026 18:21
@opencode-agent
opencode-agent Bot disabled auto-merge August 13, 2026 19:22
@seonghobae
seonghobae enabled auto-merge (squash) August 13, 2026 19:24
@opencode-agent
opencode-agent Bot disabled auto-merge August 13, 2026 22:12
@seonghobae
seonghobae enabled auto-merge (squash) August 13, 2026 22:14
@opencode-agent
opencode-agent Bot disabled auto-merge August 13, 2026 23:02
@seonghobae
seonghobae enabled auto-merge (squash) August 13, 2026 23:04
@opencode-agent
opencode-agent Bot disabled auto-merge August 13, 2026 23:53
@seonghobae
seonghobae enabled auto-merge (squash) August 13, 2026 23:56
@opencode-agent
opencode-agent Bot disabled auto-merge August 14, 2026 03:00
@seonghobae
seonghobae enabled auto-merge (squash) August 14, 2026 03:03
@opencode-agent
opencode-agent Bot disabled auto-merge August 14, 2026 04:43
@seonghobae
seonghobae enabled auto-merge (squash) August 14, 2026 04:47
@opencode-agent
opencode-agent Bot disabled auto-merge August 14, 2026 06:09
@seonghobae
seonghobae enabled auto-merge (squash) August 14, 2026 06:09
@opencode-agent
opencode-agent Bot disabled auto-merge August 14, 2026 07:17
@seonghobae
seonghobae enabled auto-merge (squash) August 14, 2026 22:01
@opencode-agent
opencode-agent Bot disabled auto-merge August 14, 2026 22:58
@seonghobae
seonghobae enabled auto-merge (squash) August 14, 2026 23:04
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 00:07
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 00:10
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 01:08
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 01:12
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 02:21
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 02:26
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 03:13
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 03:18
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 04:02
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 04:03
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 05:04
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 05:06
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 05:49
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 05:55
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 06:11
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 06:16
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 06:55
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 06:58
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 07:53
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 08:01
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 08:10
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 08:12
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 09:05
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 09:14
@opencode-agent
opencode-agent Bot disabled auto-merge August 15, 2026 09:57
@seonghobae
seonghobae enabled auto-merge (squash) August 15, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant