Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,7 @@
## 2026-07-13 - Array.from mapping optimization
**Learning:** Using `Array.from({ length: N }).map(...)` creates an intermediate array of `undefined` values which requires memory allocation and garbage collection, adding O(N) unnecessary overhead in frequently re-rendered UI components.
**Action:** Use `Array.from({ length: N }, (_, index) => ...)` to map elements directly during array creation, avoiding intermediate allocations.

## 2026-08-01 - O(1) early exit for validating byte arrays
**Learning:** Using `.every()` on large byte arrays creates O(N) intermediate callback allocations which degrades performance significantly.
**Action:** Use a standard `for` loop with an early return to achieve O(1) memory and significantly faster execution.
12 changes: 12 additions & 0 deletions apps/desktop/src/features/score/scoreStorage.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,16 @@ describe("scoreStorage bridge resolution", () => {
BRIDGE_UNAVAILABLE_MESSAGE
);
});

it("returns invalid response if byte array contains non-numbers to trigger break path", async () => {
// Stub window to bypass getInvoke null check
const mockInvoke = vi.fn().mockResolvedValue([1, 2, "not-a-number", 4]);
vi.stubGlobal("window", {
__TAURI_INVOKE__: mockInvoke
});

await expect(readScorePdf("project-1", "score-1")).rejects.toThrow(
"Invalid score bridge response"
);
});
});
15 changes: 13 additions & 2 deletions apps/desktop/src/features/score/scoreStorage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,19 @@ export async function readScorePdf(projectId: string, scoreId: string): Promise<
if (response instanceof ArrayBuffer) {
return new Uint8Array(response);
}
if (Array.isArray(response) && response.every((byte) => typeof byte === "number")) {
return Uint8Array.from(response as number[]);
if (Array.isArray(response)) {
// Performance: Avoid O(N) intermediate callback allocations from .every() on large byte arrays.
// Use a standard for loop with early return for O(1) memory and significantly faster execution.
let isValid = true;
for (let i = 0; i < response.length; i++) {
if (typeof response[i] !== "number") {
isValid = false;
break;
}
}
if (isValid) {
return Uint8Array.from(response as number[]);
}
}

throw new Error(INVALID_RESPONSE_MESSAGE);
Expand Down
Loading