feat(core): bound raw WebDriver BiDi response documents - #185
Draft
seonghobae wants to merge 5 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on exact PR #184 head
31faaac806ed98384fc84a759b96af94573a3955.Buyer gap
The existing BiDi stack had no explicit pre-parser resource bound for a raw response document. This PR adds a narrow byte-budget boundary before any future JSON parser receives the document.
Test-first lineage
67d0a3be55a054fffbd59647a0f1304c0bc194cffirst exposed a rustfmt diagnostic.192b6f27a426905070755f51c5b41d644dfb5513produced the semantic RED in CI32085078529, Rust contracts job95555868811: formatting passed and locked workspace compilation failed because the required response-document API did not exist.f4cf87ba6daddecd861a9ec1e1dc3f1b9ecad538added the bounded document type, typed errors, byte limit, and crate export.afe81c45b5d5be09f980bbd1dd153874b628fef1also records the contract inCHANGELOG.md.Current contract
Exact-current evidence
On unchanged head
afe81c45b5d5be09f980bbd1dd153874b628fef1against unchanged prerequisite31faaac806ed98384fc84a759b96af94573a3955:32085416708: success;95556825962: success;95556825921: success;32085416789: success;Protected-main-only Security/SAST/OpenCode/Noema/Strix evidence is absent for this stacked Draft and is not treated as passing.
Keep Draft while #184 and its prerequisite stack remain active. No predecessor checks or reviews transfer. This scheduled actor does not merge, self-approve, alter workflows, add secrets, weaken checks, tag, or publish.