feat(core): serialize bounded WebDriver BiDi locateNodes commands - #181
Draft
seonghobae wants to merge 8 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on exact PR #174 head
ec6293eb86666a5de335d0a71674215a8953db33.Buyer gap
#174 closes protocol-proof and node-admission confusion, but its current truth boundary explicitly stops before serializing or transmitting a WebDriver BiDi command. This child owns the next bounded boundary: deterministic, fail-closed serialization of the reviewed
browsingContext.locateNodesaccessibility query into an exact WebDriver BiDi command envelope. It performs no transport I/O and grants no browser, policy, destination, or typed-input authority.Implemented contract
Current exact head
d28836ae8c0f2096f214d681f001d60e9fcb780b:js-uintcommand IDs, including 0 and9007199254740991, and rejects largeru64values;maxNodeCount, and fixed minimal serialization options already carried byWebDriverBiDiAccessibilityQuery;CHANGELOG.md; andlocateNodesparameter shape in the W3C WebDriver BiDi Editor’s Draft dated 20 July 2026 indocs/doctoring/browser-agent-protocols.md.This remains an inert transport value: it does not authenticate a browser or adapter, perform transport I/O, bind the command to current OriginWeave session/context/origin authority, correlate a response, admit returned nodes, or authorize policy/typed input.
Exact-head evidence
For unchanged exact head
d28836ae8c0f2096f214d681f001d60e9fcb780b:32058217738: success;32058217732: success;These checks are head-specific; no predecessor evidence is transferred.
Stack discipline
Keep Draft while #174 and its prerequisites remain active. PR #182 owns the next response-correlation slice and is stacked on this head. No predecessor check/review/coverage evidence transfers. This scheduled actor does not merge, self-approve, alter workflows, add secrets, weaken checks, tag, or publish.