Skip to content

feat: land the comparison strip on the opened Demo Corp row (v0.99.0) - #201

Merged
seonghobae merged 1 commit into
feat/role-responsibility-agent-ontologyfrom
feat/analysis-run-comparison-strip-landing
Aug 17, 2026
Merged

feat: land the comparison strip on the opened Demo Corp row (v0.99.0)#201
seonghobae merged 1 commit into
feat/role-responsibility-agent-ontologyfrom
feat/analysis-run-comparison-strip-landing

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Buyer gap

After #199, Open period report 2026-W02 switched grouping to Corporate entity and marked Demo Corp current. That landing only became obvious when the week also changed. After make seed the home week is already 2026-W02, so the period field did not move and the comparison strip stayed visually unlanded.

What changed

Stacked on #200 (feat/analysis-run-sql-constants). Do not merge before #74#200.

  • Already on 2026-W02: the grouping comparison strip lands on Demo Corp (current + focused).
  • Changing the week first still focuses the report period field.
  • Mean θ stays on the period-report panel. No TEPP theta is invented.

Tests

  • frontend/src/App.test.tsx — same-week Open period report 2026-W02 focuses Compare corporate_entity: Demo Corp.
  • Existing week-change test still focuses the period field.

Next action: Keep #74 unmerged until independent review. Do not merge this PR or #200 before #74.

@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4596b661-a20e-4cf5-9c82-76eb2bd905b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae changed the base branch from feat/analysis-run-sql-constants to feat/role-responsibility-agent-ontology August 17, 2026 01:49
When the operator is already on 2026-W02, Open period report focuses
the Demo Corp comparison chip instead of the unchanged period field.
@seonghobae
seonghobae force-pushed the feat/analysis-run-comparison-strip-landing branch from e510a30 to 32b09a7 Compare August 17, 2026 01:50
@seonghobae
seonghobae merged commit fbcd4df into feat/role-responsibility-agent-ontology Aug 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant