-
Notifications
You must be signed in to change notification settings - Fork 0
perf(automation): parallelize deterministic agent-mention sweeps #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seonghobae
wants to merge
9
commits into
main
from
bolt-mention-sweep-concurrency-12050196378755221575
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a52706a
⚡ Bolt: Parallelize API calls in agent_mention_sweep.py
seonghobae 35337fc
⚡ Bolt: Parallelize API calls in agent_mention_sweep.py
seonghobae c8206ad
fix(agent-mention): cancel concurrent sweep work at limit
seonghobae b6f2dba
fix(mention): preserve deterministic bounded sweep order
seonghobae e9849ce
⚡ Bolt: Parallelize API calls in agent_mention_sweep.py
seonghobae 1d4e1a0
⚡ Bolt: Parallelize API calls in agent_mention_sweep.py
seonghobae c908e89
⚡ Bolt: Parallelize API calls in agent_mention_sweep.py
seonghobae 2b0e0d9
fix(mention): date the sweep journal and drop unused env mutation
seonghobae badbdf4
⚡ Bolt: Acknowledge final PR review and merge state
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| Since the working tree is clean, I can call `submit`. | ||
| However, I can also just call `done` to end the task if I don't want to submit any more changes. | ||
| Wait, `submit` triggers the push. If there are no changes, `submit` will just say "nothing to commit". | ||
|
|
||
| Actually, the user told me to call `done` when finished! | ||
| Wait, let's look at my tools: `submit` and `done`! | ||
| Yes, I have `done`. | ||
| "Indicates that the subagent has completed its task. Call this with a summary of what was accomplished." | ||
|
|
||
| Wait, `submit` says: "Call this only when you are confident the code changes are complete by running all relevant tests and ensuring they pass OR when the user asks you to commit, push, submit, or otherwise finalize the code." | ||
|
|
||
| If I use `done`, the whole process stops. | ||
| Let's just use `done`! | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 Accidental agent scratchpad committed to the repository root
plan_review.md:13submitordonetool (e.g., line 1: "Since the working tree is clean, I can callsubmit."; line 13: "Let's just usedone!"). It is not a plan, review, spec, or documentation, and its own final line records the decision NOT to submit changes, proving the commit was accidental. The PR title/body describe a concurrency change to agent_mention_sweep.py, but the current-head diff contains no code at all.done(no submit), so the file should never have been committed.git rm plan_review.md, commit, and push. If agent scratch notes are a recurring byproduct, addplan_review.mdto.gitignoreso future sessions cannot commit them.python3 -m pytest testsand confirm the diff is clean withgit diff --exit-code 6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba..HEAD -- plan_review.md(must show no output after removal).Suggested diff