fix(ci): download pinned uv 0.12.1 from GitHub Releases - #1116
Conversation
releases.astral.sh now returns HTTP 403 for the pinned archive and blocks org-wide OpenCode coverage-evidence. Keep the same SHA-256 pin and allow only one hop onto GitHub's official release-asset hosts. Closes #1109 Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
@coderabbitai review |
|
seonghobae
left a comment
There was a problem hiding this comment.
Independent last-push review of exact head c1f388737e0684312644aac4191b44803100cfe0.
Org-wide coverage-evidence was dying because releases.astral.sh 403s the pinned uv 0.12.1 archive. This keeps TRUSTED_UV_VERSION and the SHA-256 pin, moves the sink to GitHub Releases, and allows exactly one github.com hop onto release-assets.githubusercontent.com or objects.githubusercontent.com. Second hops, userinfo, non-HTTPS, and nondefault ports fail closed. Product CI on this SHA is green: Python 3.10/3.14 quality gates, coverage-evidence, pip-audit, Strix, CodeQL. Last-pusher cursoragent, author cursor[bot]. No COPILOT token.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthrough고정된 Changes신뢰된 uv 다운로드 경로
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Downloader as _download_trusted_uv_archive
participant Opener as urllib opener
participant Redirects as _TrustedUvReleaseAssetRedirects
participant CDN as GitHub release asset CDN
Downloader->>Opener: 고정 GitHub Releases URL 요청
Opener->>Redirects: Location 리디렉션 전달
Redirects->>CDN: 공식 asset 호스트로 단일 홉 허용
CDN-->>Downloader: 최종 응답 URL과 아카이브 반환
Downloader->>Downloader: 최종 HTTPS 출처 검증 및 SHA-256 확인
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Buyer-visible gap
Org-wide OpenCode
coverage-evidencewas failing before any product test ran. The pinneduv0.12.1 archive atreleases.astral.shnow returns HTTP 403, so required review evidence could not be measured. That blocked formal OpenCode verdicts on live product heads, including ContextualWisdomLab/fast-mlsirm#928, ContextualWisdomLab/fast-mlsirm#959, ContextualWisdomLab/fast-mlsirm#971, and ContextualWisdomLab/scopeweave#490.What to do next
Review this exact-head change, then let the independent non-author approval and current-head checks land it on protected
main. After merge, re-dispatch OpenCode on those product heads so they receive a real semantic verdict instead of an infrastructureCHANGES_REQUESTED.Bounded change
TRUSTED_UV_VERSION = 0.12.1and the existing SHA-256 pin90b2f223fb69d19db49e117da601f64978593417988530aa733d456141b4bcbb.urlopensink tohttps://github.com/astral-sh/uv/releases/download/0.12.1/uv-x86_64-unknown-linux-gnu.tar.gz.github.comontorelease-assets.githubusercontent.comorobjects.githubusercontent.com.COPILOT_GITHUB_TOKEN. Do not change the review-agent key scheme.Verification
1132 passed,16subtests,scripts/cistatement/branch coverage 100%, interrogate 100%.21,760,555bytes, SHA-256 matches the existing pin.releases.astral.shas HTTP 403 with noLocationheader.Closes #1109.
Refs ContextualWisdomLab/fast-mlsirm#971, ContextualWisdomLab/scopeweave#490.
Summary by CodeRabbit
버그 수정
uv다운로드 경로를 공식 GitHub Releases로 변경했습니다.문서
uv다운로드 출처와 리디렉션 보안 요구사항을 최신 동작에 맞게 업데이트했습니다.테스트