Skip to content

fix(strix): classify ModelBehaviorError with zero findings as backend skip - #1090

Closed
seonghobae wants to merge 1 commit into
mainfrom
fix/strix-modelbehaviorerror-classifier
Closed

fix(strix): classify ModelBehaviorError with zero findings as backend skip#1090
seonghobae wants to merge 1 commit into
mainfrom
fix/strix-modelbehaviorerror-classifier

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Why

Required Strix failed closed on ModelBehaviorError with Vulnerabilities 0 (LineageWeave #74 job flake). That is an LLM classifier outage, not a security finding.

Change

Add ModelBehaviorError to the existing backend-unavailable classifier in .github/workflows/strix.yml. Neutral skip still requires no Vulnerabilities [1-9]. That fail-closed range is unchanged.

Tests

tests/test_strix_modelbehaviorerror_classifier.py proves:

  • ModelBehaviorError + Vulnerabilities 0 is neutralized
  • ModelBehaviorError + Vulnerabilities 1 stays fail-closed
  • ModelBehaviorError + Vulnerabilities 9 stays fail-closed
  • Vulnerabilities 0 without a backend signal is not neutralized

Do not self-approve. Independent exact-head APPROVE required.

… skip

Vulnerabilities [1-9] stay fail-closed. A ModelBehaviorError flake with
Vulnerabilities 0 no longer blocks required Strix.
@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9365011f-449b-4631-a0e3-3004a2fa0705

📥 Commits

Reviewing files that changed from the base of the PR and between c47afc2 and ba10a03.

📒 Files selected for processing (3)
  • .github/workflows/strix.yml
  • CHANGELOG.md
  • tests/test_strix_modelbehaviorerror_classifier.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@cwl-noema-review Independently review exact head ba10a03dff073eea92405f496e4e891b8ceeb6ec. ModelBehaviorError + Vulnerabilities 0 is a backend skip. Vulnerabilities [1-9] stay fail-closed. Do not self-approve. Do not weaken the finding gate.

Copy link
Copy Markdown
Contributor Author

Duplicate of #1091.

#1090 adds a bare ModelBehaviorError token, which a source-file literal can spoof. #1091 requires the trusted SDK prefix (pydantic_ai.exceptions.ModelBehaviorError or a LiteLLM wrap), wires the gate (is_model_behavior_error), and keeps Vulnerabilities [1-9] fail-closed.

#1091 is the G4 landing vehicle. Closing this PR unmerged. Not an approval of #1091.

@seonghobae seonghobae closed this Aug 17, 2026
@seonghobae seonghobae reopened this Aug 17, 2026
@seonghobae seonghobae closed this Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Reclose: this remains the weaker duplicate of #1091 (bare ModelBehaviorError can be spoofed by a source literal). Not an approval of #1091. Independent exact-head APPROVE still required on #1091.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant