fix(pip-audit): keep index-url locks hashed and reject symlink parents - #1051
Open
cursor[bot] wants to merge 1 commit into
Open
fix(pip-audit): keep index-url locks hashed and reject symlink parents#1051cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Audit complete SHA-256 locks with --disable-pip so --index-url stays configuration, -r includes do not earn resolver bypass, and directory-symlink parents fail closed.
seonghobae
force-pushed
the
cursor/bc-9e735bff-0cbd-4bb6-abcc-b5dad2b94830-fc67
branch
from
August 17, 2026 00:57
3940cbd to
9daa0b1
Compare
seonghobae
marked this pull request as ready for review
August 17, 2026 00:57
seonghobae
enabled auto-merge (squash)
August 17, 2026 00:57
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible gap
#969 at
a2f3a7efstill sends a complete hashed lock that only adds--index-urlback through pip's resolver. That recreates the #961ResolutionImpossiblefalse vulnerability. A presented path whose intermediate parent is a directory symlink also lacked a fail-closed guard (CWE-22 / CWE-59).What to do next
Land this successor instead of merging #969 at
a2f3a7ef. After exact-head required checks and a non-author current-head review succeed, merge this branch. Do not merge #969 in parallel.Bounded change
--index-url,--extra-index-url=...) as non-package lines so an otherwise complete SHA-256 lock still getspip-audit --disable-pip.-r/-c/-eincludes on the resolver path.--require-hashes --no-depswith no lock change and no review-agent credential change.Verification
Local exact-tree evidence:
1146 passed,scripts/cistatement/branch coverage 100%, interrogate 100%.Refs #969, #961, #952.