feat: Add special snowflake path for internal dns usage #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanfeng
previously approved these changes
Feb 27, 2025
Contributor
jonathanfeng
left a comment
jonathanfeng
left a comment
There was a problem hiding this comment.
I think there are some lint errors that are non-blocking but LGTM if tested
|
@milesadkins run the following on your code: ./scripts/format |
lingxi-at-contextual
previously approved these changes
Feb 28, 2025
Contributor
lingxi-at-contextual
left a comment
lingxi-at-contextual
left a comment
There was a problem hiding this comment.
LGTM!! Thank you for bringing this to our SDK!! 🚀
milesadkins
dismissed stale reviews from lingxi-at-contextual and jonathanfeng
via
fc90d3e
lingxi-at-contextual
approved these changes
Mar 1, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the contextual python SDK to be used inside our Snowflake Native App services without requiring an API key