Skip to content

Conversation

@arahman80
Copy link

Updates:

  • catch_names & short_name no longer appear in embed if None
  • slightly improved readability

Updates:
  - catch_names & short_name no longer appear in embed if None
  - slightly improved readability
@arahman80 arahman80 closed this by deleting the head repository Aug 21, 2025
@ContestedWheel
Copy link
Owner

ContestedWheel commented Aug 26, 2025

Hi there, I have tested this PR for myself and loved it! I have been wanting to achieve this for a while but never got the motivation to do so.

Can I have permission to add this to the main repository? If yes, then I will let you make any other adjustments if needed before adding the changes. If not, I can understand.

Thanks again for the PR!

@arahman80
Copy link
Author

Hello,

Thank you for your interest in my PR. If you are satisfied with it, then you may merge it. Please let me know if you would like any adjustments - whether those be for code style, functionality, or optimization.

Abdul

p.s., The closure of this PR was a mistake. I was unaware (due to lack of experience with GitHub) that deleting the repository that holds your fork will also close any PRs you have made to the main repository.

@ContestedWheel
Copy link
Owner

ContestedWheel commented Aug 26, 2025

I don't think anything has to be changed in my opinion, but you can always create another PR for minor fixes if you change your mind. I have already merged the changes.

Thanks again!

@arahman80
Copy link
Author

Okay. No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants