Skip to content

Conversation

@evgenyfedoruk
Copy link
Contributor

"name" should be specified instead of "display_name".
Link to the issue: #963

"name" should be specified instead of "display_name".
@auhlig
Copy link
Member

auhlig commented Mar 8, 2017

Hi @evgenyfedoruk,
Thanks investigating and submitting this PR.
As the attribute was display_name before and changed to name later, would it make sense to have both methods in our lib? So how about keeping the displayName method and just adding the following? Eventually even adding deprecated annotation on the displayName method.

public PortListOptions name(String name) {
        return add("name", name);
    }

"name" attribute should be specified instead of "display_name".
The displayName(Strinf displayName) method became depricated.
New method name(String name) added.
@evgenyfedoruk
Copy link
Contributor Author

Hi @auhlig
You right, pushed an update with new method and old method deprecated.

@Deprecated
public PortListOptions displayName(String displayName) {
return add("display_name", displayName);
return add("name", displayName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one stays "display_name", not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh.. sure.

@auhlig auhlig merged commit 0f3f038 into ContainX:master Mar 9, 2017
@auhlig
Copy link
Member

auhlig commented Mar 9, 2017

Many thanks for contributing @evgenyfedoruk.

@auhlig auhlig added this to the 3.0.4 Release milestone Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants