-
Notifications
You must be signed in to change notification settings - Fork 364
Fixing port name list option. #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"name" should be specified instead of "display_name".
|
Hi @evgenyfedoruk, |
"name" attribute should be specified instead of "display_name". The displayName(Strinf displayName) method became depricated. New method name(String name) added.
|
Hi @auhlig |
| @Deprecated | ||
| public PortListOptions displayName(String displayName) { | ||
| return add("display_name", displayName); | ||
| return add("name", displayName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one stays "display_name", not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh.. sure.
|
Many thanks for contributing @evgenyfedoruk. |
"name" should be specified instead of "display_name".
Link to the issue: #963