Skip to content

Conversation

@test-1pro
Copy link
Contributor

Hi, I'm Taemin.
I added two ipv6 properties for creating and getting subnet.

  • ipv6_address_mode
    : The IPv6 address modes specifies mechanisms for assigning IP addresses. Value is slaac, dhcpv6-stateful, dhcpv6-stateless or null.
  • ipv6_ra_mode
    : The IPv6 router advertisement specifies whether the networking service should transmit ICMPv6 packets, for a subnet. Value is slaac, dhcpv6-stateful, dhcpv6-stateless or null.

ActionResponse ->
an administrative password to access the evacuated or rebuilt instance.
Add Optional Parameters for ipv6(ipv6_address_mode, ipv6_ra_mode)
@auhlig
Copy link
Member

auhlig commented Mar 8, 2017

Hi @taemin77,
Thanks for the work.

Any objections from your side @vinodborole on changing method signature of NeutronSubnetNoGateway and NeutronSubnet?

@vinodborole
Copy link
Contributor

All good, just added one comment on formatting

@test-1pro test-1pro closed this Mar 10, 2017
@test-1pro test-1pro reopened this Mar 10, 2017
@test-1pro
Copy link
Contributor Author

merged commit ?

{
    "services": [
        {
            "binary": "cinder-scheduler",
            "host": "host1",
            "state": "UP",
            "status": "ENABLED",
            "updated_at": "2012-10-29T13:42:02.000000",
            "zone": "nova"
        },
        {
            "binary": "cinder-volume",
            "host": "host1",
            "state": "UP",
            "status": "ENABLED",
            "updated_at": "2012-10-29T13:42:05.000000",
            "zone": "nova"
        }
    ]
}
@test-1pro
Copy link
Contributor Author

Hi,
I added Block Storage Service List API.
I wanted to create "new pull request", but I could't seem to do it because previous pull request didn't finish.

@auhlig
Copy link
Member

auhlig commented Mar 10, 2017

HI @taemin77, the previous PR wasn't merged yet.
Could you address @vinodborole's comment first?

You can push the changes for the block storage to a new branch and create a PR from there.
Would prefer this in the future to not mix up the PRs.

@test-1pro
Copy link
Contributor Author

Hi,
Where can I find @vinodborole 's comment?
Could you let me know how to check comment?
I will create new branch about block storage.
Thank you.

@auhlig
Copy link
Member

auhlig commented Mar 13, 2017

Ah. Right. Can't see it too. Didn't you comment @vinodborole?

@auhlig
Copy link
Member

auhlig commented Mar 13, 2017

@taemin77 Could you revert to fe7413c so we don't mix things up here and you already created a separate PR for the block storage commits?

…or ipv6(ipv6_address_mode, ipv6_ra_mode)"

This reverts commit fe7413c.
@test-1pro
Copy link
Contributor Author

Ok, I did it.

@vinodborole
Copy link
Contributor

LGTM

@auhlig auhlig merged commit cc4da64 into ContainX:master Mar 15, 2017
@auhlig auhlig added this to the 3.0.4 Release milestone Mar 15, 2017
@auhlig
Copy link
Member

auhlig commented Mar 15, 2017

Many thanks for contributing @taemin77

@test-1pro
Copy link
Contributor Author

@auhlig I have question.
"openstack4j-3.0.4-20170316.085041-28-sources.jar" don't have subent ipv6 propertise.
Didn't subnet ipv6 include in SNAPSHOT yet?

@auhlig
Copy link
Member

auhlig commented Mar 17, 2017

It should be in the latest snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants