Skip to content

Conversation

@jcoste-orange
Copy link
Contributor

Fix #855

@vinodborole
Copy link
Contributor

Thanks a lot @jcoste-orange. LGTM, what do you think @auhlig ?

@auhlig
Copy link
Member

auhlig commented Nov 23, 2016

Nitpicking: We could have saved a couple of characters as response.body().close(); and response.close(); are equivalent.

I guess it's good to merge the way it is now. Thanks @jcoste-orange.

@auhlig auhlig added this to the 3.0.4 Release milestone Nov 23, 2016
@jcoste-orange
Copy link
Contributor Author

There's no method close on class okhttp3.Response. So @auhlig I don't understand your comment.

@auhlig
Copy link
Member

auhlig commented Nov 23, 2016

True. I looked at a newer version of the api. Sorry for the confusion

@auhlig auhlig merged commit 74f2aef into ContainX:master Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants