Skip to content

Whaon patch issue 802 #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auhlig merged 4 commits into from
Sep 22, 2016
Merged

Whaon patch issue 802 #819

auhlig merged 4 commits into from
Sep 22, 2016

Conversation

@whaon
Copy link
Contributor

@whaon whaon commented Sep 20, 2016

fix enhancement issue #802

vinodborole
vinodborole reviewed Sep 20, 2016
View reviewed changes
core/src/main/java/org/openstack4j/openstack/internal/BaseOpenStackService.java Outdated

private static ThreadLocal<String> reqIdContainer = new ThreadLocal<String>();

public static final String X_OPENSTACK_REQUEST_ID = "x-openstack-request-id";
Copy link
Contributor

@vinodborole vinodborole Sep 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be part of https://github.com/ContainX/openstack4j/blob/master/core/src/main/java/org/openstack4j/core/transport/ClientConstants.java class?

Copy link
Contributor Author

@whaon whaon Sep 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a good idea

@vinodborole
Copy link
Contributor

vinodborole commented Sep 20, 2016

@auhlig Can you please review?

@auhlig
Copy link
Member

auhlig commented Sep 20, 2016

Besides the comment above LGTM

@whaon
Copy link
Contributor Author

whaon commented Sep 21, 2016

Hi,it's ok in jdk7 but failed in jdk8.
I can't get the job log,pls give me a hand
Thanks

@auhlig
Copy link
Member

auhlig commented Sep 21, 2016

Connection reset while trying to get a dependency from maven central -.-
Could you close and reopen the PR to trigger travis build again?

@whaon whaon closed this Sep 21, 2016
@whaon whaon reopened this Sep 21, 2016
@auhlig
Copy link
Member

auhlig commented Sep 22, 2016

Good to merge @vinodborole ?

@auhlig auhlig added this to the 3.0.3 Release milestone Sep 22, 2016
@vinodborole
Copy link
Contributor

vinodborole commented Sep 22, 2016

LGTM

@auhlig auhlig merged commit 7cf376f into ContainX:master Sep 22, 2016
@whaon whaon mentioned this pull request Oct 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinodborole vinodborole vinodborole left review comments

@auhlig auhlig auhlig approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

3.0.3 Release

Development

Successfully merging this pull request may close these issues.

4 participants

@whaon @vinodborole @auhlig @tongh-qtl