-
Notifications
You must be signed in to change notification settings - Fork 364
Dividing Builder-API by Identity version #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As discussed with @auhlig via PM just now, this idea of using This same pattern can then be used to support different versions of the other OpenStack services, and has the advantage that users of OS4J v3.0 would not have a breaking change when using V3 user objects. |
|
@auhlig @dhague I agree with the |
|
|
|
@auhlig @dhague - I know this is a PR :) But wanted to introduce @vinodborole who made a comment above. He's been a big contributor as well. Do you mind also reviewing his latest PR which is targeted for V3 - PR #671 . @vinodborole - Darren and Arno did the V3 work, infact built the whole 3.0.0 release. |
|
@gondor Thanks for introducing me to the team; its a privilege working with you guyz. Let me know what you think about my PR; |
|
Currently its done manually by me. Working on integrating merged changes to deploy new snapshots via Travis CI. |
|
Hey @gondor, @dhague, @vinodborole, I added commit b269507 implementing what we discussed. I also extended that pattern to the other services. Comes with groovy tests. Let me know what you think. |
|
LGTM |
|
LGTM - great job! |
As discussed in #666 this introduces the BuildersV2 and BuildersV3 to make it less likely to get confused by the 2 different Identity versions.
What do you think @gondor , @dhague ?