Skip to content

Fix for issue #1124:openstack4j mistaken heat-cfn service as heat ser… #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vinodborole merged 1 commit into from
Oct 10, 2018
Merged

Fix for issue #1124:openstack4j mistaken heat-cfn service as heat ser… #1142

vinodborole merged 1 commit into from
Oct 10, 2018

Conversation

@newinone
Copy link

@newinone newinone commented Jan 21, 2018

This is the proposed fix.

  • The fix worked for our environment.
  • However it did change the previous matching behavior.
  • I'm open to change the service pattern as long as the negative tests pass.

@auhlig
Copy link
Member

auhlig commented Jan 22, 2018

Thanks a lot @newinone. Can we test this somehow?

@auhlig auhlig added this to the 3.1.1 Release milestone Jan 22, 2018
@vinodborole vinodborole merged commit 86cc59f into ContainX:master Oct 10, 2018
@xotama xotama mentioned this pull request Dec 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement Test Cases Required

Projects

None yet

Milestone

3.1.1 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@newinone @auhlig @vinodborole