Heat service, adding support for stack abandon and adopt #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
auhlig
reviewed
Jan 22, 2018
|
|
||
| @Override | ||
| public String toString() { | ||
| return "HeatAdoptStackData{" + "id=" + id + ", name=" + name + ", status=" + status + ", resources=" + resources + '}'; |
Member
There was a problem hiding this comment.
I'd prefer
public String toString() {
MoreObjects.toStringHelper(this).omitNullValues()
.add("id", id)
.add(...)
.toString();
}
What do you think @akemr?
Contributor
Author
There was a problem hiding this comment.
Sure, no problem. My simple toString was just generated by IDE.
@auhlig Should I do the change in my branch and add the commit to this pull request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements issue #1135.
There are 2 new methods in
heat.StackService: abandon and adopt. New interfaceAdoptStackDatadescribesadopt_stack_dataelement, used as an input for stack adoption and as a return value for stack abandoning.Basic unit tests are included. The code was tested against real Openstack instance as well.