Issue : #[1070](https://github.com/ContainX/openstack4j/issues/1070) #1072
Conversation
Description: 1. Updated Apache httpclient version and corresponding code for IPv6+ https issue.
2. Added support for IgnoreSSLVerification and custom SSLHostnameVerifier.
|
LGTM |
|
Will take a look tomorrow. |
connectors/resteasy/pom.xml
Outdated
| <artifactId>httpclient</artifactId> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
Why excluding the httpclient from resteasy? Wouldn't upgrading resteasy itself be the cleaner solution?
There was a problem hiding this comment.
We tried using higher version of resteasy jar. But it did not work because of the version resteasy usage of httpclient. There are few SSL related bug fix only in 4.5.3 version.
https://archive.apache.org/dist/httpcomponents/httpclient/RELEASE_NOTES-4.5.x.txt
Maybe in near future when resteasy provides corresponsing implementation. we can upgrade resteasy and remove execlusion.
There was a problem hiding this comment.
Which version of resteasy did you try?
There was a problem hiding this comment.
I used 3.1.3.Final. now I can see that they have released new version (3.1.4.Final). I will try to use this version and will upgrade if it works.
There was a problem hiding this comment.
Hi @auhlig , Even new one also come with httpcomponents:httpclient:jar:4.5.2
[INFO] ------------------------------------------------------------------------
[INFO] Building OpenStack4j RestEasy Connector 3.0.5-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ openstack4j-resteasy ---
[INFO] org.pacesys.openstack4j.connectors:openstack4j-resteasy:jar:3.0.5-SNAPSHOT
[INFO] +- org.jboss.resteasy:resteasy-jaxrs:jar:3.1.4.Final:compile
[INFO] | +- org.jboss.spec.javax.ws.rs:jboss-jaxrs-api_2.0_spec:jar:1.0.1.Beta1:compile
[INFO] | +- org.jboss.resteasy:resteasy-jaxrs-services:jar:3.1.4.Final:compile
[INFO] | +- org.jboss.spec.javax.annotation:jboss-annotations-api_1.2_spec:jar:1.0.0.Final:compile
[INFO] | +- javax.activation:activation:jar:1.1.1:compile
[INFO] | +- org.apache.httpcomponents:httpclient:jar:4.5.2:compile
There was a problem hiding this comment.
Hi @auhlig, tried setting up IntelliJ but couldn't get succeed. got stuck in regular office tasks.
I can send you git patch if you are ok. I will try to get some time this weekend and finish the task otherwise.
There was a problem hiding this comment.
No worries. I'm also happy to take this in it's current state. Just wanted to know, so do not postpone the release unnecessarily. Many thanks for all the work!
So is it good to merge from your side @kushalagrawal1?
There was a problem hiding this comment.
@aiziyuer can you please apply this patch and try?
<change the extension of the file to ".patch">
https://github.com/ContainX/openstack4j/files/1291381/issue_1070_patch.txt
There was a problem hiding this comment.
Hi @auhlig @vinodborole, I have done all required changes from my side. can you please review it once so it can be merged, or if there is any change need to be done will not affect release.
Description: Updated Resteasy client version from 2.x to 3.x.
|
Hi @auhlig @vinodborole , I tried fixing the issue but I failed.. Here is the patch for the same. Can you please check what is the silly mistake I am doing ? |
Description: Fixed Test cases.
|
@auhlig @vinodborole it is ready to merge. can you please review it once. |
|
Very cool @kushalagrawal1 💯 |
|
LGTM @auhlig, good work @kushalagrawal1 👍 |
4 participants
Description: 1. Updated Apache httpclient version and corresponding code for IPv6+ https issue.
2. Added support for IgnoreSSLVerification and custom SSLHostnameVerifier.