Skip to content

SenlinNodeService: details about physical object that backs the node #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auhlig merged 1 commit into from
May 4, 2017
Merged

SenlinNodeService: details about physical object that backs the node #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core/src/main/java/org/openstack4j/api/senlin/SenlinNodeService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ public interface SenlinNodeService {
*/
Node get(String nodeID);

/**
* returns details of a {@link Node}
* @param nodeID Id of {@link Node}
* @param showDetails {@literal true} to retrieve the properties about the physical object that backs the node
* @return Node
*/
Node get(String nodeID, boolean showDetails);

/**
* Deletes the specified {@link Node} from the server.
*
Expand Down
8 changes: 7 additions & 1 deletion core/src/main/java/org/openstack4j/openstack/senlin/internal/SenlinNodeServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,14 @@ public Node create(NodeCreate newNode) {

@Override
public Node get(String nodeID) {
return get(nodeID, false); //false for backward compatibility
}

@Override
public Node get(final String nodeID, final boolean showDetails) {
checkNotNull(nodeID);
return get(SenlinNode.class, uri("/nodes/%s", nodeID)).execute();
//see at https://developer.openstack.org/api-ref/clustering/?expanded=show-node-details-detail
return get(SenlinNode.class, uri("/nodes/%s", nodeID)).param("show_details", showDetails).execute();
}

@Override
Expand Down