Identity v3 with scopeToProject(Identifier.byName(projectName))

[draoullig]

Hi,

When you use the method scopeToProject with just Identifier.byName(projectName), the identification fails.
If you use scopeToProject with Identifier.byName(projectName) and Identifier.byName(domainName), the identification is good.
By comparing the methods ScopeProject create... from the class openstack4j/core/src/main/java/org/openstack4j/openstack/identity/v3/domain/KeystoneAuth.java, it seems that lack the clause:
else {
scope.name = project.getId();
}
in the method public static ScopeProject create(Identifier project).

Best regards.

Frédéric.

[auhlig]

Hi @draoullig,

Scoping to a project just by name isn't possible as the project name is only unique within a domain.
You can either use the

.scopeToProject(Identifier.byId(projectId))

as the id of the project is unique across domains or alternatively

.scopeToProject(Identifier.byName(projectName), Identifier.byName(domainName))
// or
.scopeToDomain(Identifier.byName(domainName)) // domain id or name

a combination of project name and domain.

Although I admit the code you found looks suspicious the test and the recorded client-openstack interactions looks good.

[draoullig]

Hi,

Thanks for the explanation, now I understand the implementation.

Bests regards.

Frederic.

2016-08-16 22:44 GMT+02:00 Arno Uhlig notifications@github.com:

Hi @draoullig https://github.com/draoullig,

Scoping to a project just by name isn't possible as the project name is
only unique within a domain.
You can either use the

scopeToProject(Identifier.byId(projectId))

as the id of the project is unique across domains or alternatively

.scopeToProject(Identifier.byName(projectName))
.scopeToDomain(Identifier.byName(domainName)) // domain id or name

a combination of project name and domain.

Although I admit the code you found looks suspicious the test and the
recorded client-openstack interactions looks good.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#776 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD-oJnQ_yhmD-TTh6rHUATSMVecjveSwks5qgiE2gaJpZM4JlVsA
.

[ScottMaclure]

@auhlig perhaps add an example of scoping by project name + domain name in the getting started guide, this tripped me up because I was previously scoping by project id. It makes sense now after reading this page.

[vinodborole]

i have updated the doc for getting-started

[auhlig]

Thanks @vinodborole

[vinodborole]

@auhlig i have made committed the change but i do not see the changes on the page..can u check my latest commit.

[auhlig]

Your commit looks fine. It was just not deployed. Is that only triggered on PR merge?

[vinodborole]

not sure, i did a direct commit to master... @gondor can you check.

[auhlig]

yeah. i can see it. i don't think you did anything wrong. that should have worked.
can deployment be (re-)triggered manually?

[auhlig]

log looks good https://travis-ci.org/ContainX/openstack4j.com/builds/164855887. Image pushed successfully.

[gondor]

There was an error on deploy. I need to look into it but the change did make it into the container :)

[gondor]

Should be fixed. Build 34 from travis was deployed

[vinodborole]

Thanks @gondor 👍