Skip to content

Added self reference to custom element to extend vm method. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@contasystemer/angularjs-custom-element",
"version": "1.0.1",
"version": "1.0.2",
"description": "AngularJS custom element module provides functionality to wrap directive/component with custom element.",
"main": "index.js",
"scripts": {
Expand Down
31 changes: 19 additions & 12 deletions src/cs-custom-element.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

var service = {
create: create,
extendVm: extendVm,
helper: {
decode: decode,
},
Expand Down Expand Up @@ -130,17 +131,6 @@
*/
identity: _.identity,
},
/**
* @ngdoc method
* @name csCustomElement#extendVm
*
* @description
* Extends custom element scope's `vm`.
*
* @param {Object} vm Current `vm`.
* @returns {Object} Extended `vm`.
*/
extendVm: _.identity,
};

return service;
Expand Down Expand Up @@ -457,7 +447,7 @@

// Create custom element scope which is used as a store of data and as a parent for component scope.
self.$scope = $rootScope.$new();
self.$scope.vm = service.extendVm({});
self.$scope.vm = service.extendVm(self, {});

return self;
};
Expand Down Expand Up @@ -718,6 +708,23 @@
);
}

// VM

/**
* @ngdoc method
* @name csCustomElement#extendVm
*
* @description
* Extends custom element scope's `vm`.
*
* @param {HTMLElement} self Reference to the custom element.
* @param {Object} vm Current `vm`.
* @returns {Object} Extended `vm`.
*/
function extendVm(self, scope) {
return scope;
}

// DECODERS

/**
Expand Down