-
Notifications
You must be signed in to change notification settings - Fork 20
Releases/2.1.0 #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releases/2.1.0 #79
Conversation
1. Update action steps to their latest versions. 2. Pass the build platform as a variable to target for the given platform
|
|
|
||
| if (dcrOptions.Ignore_Server_Certificate_Errors) | ||
| { | ||
| ServerCertificateCustomValidationCallback += (sender, cert, chain, sslPolicyErrors) => true; |
Check failure
Code scanning / SonarCloud
Server certificates should be verified during SSL/TLS connections
| { | ||
| // Get the cdr arrangement id from the http header. | ||
| if (!request.Headers.ContainsKey(HEADER_INJECT_CDR_ARRANGEMENT_ID)) | ||
| if (!request.Headers.TryGetValue(HEADER_INJECT_CDR_ARRANGEMENT_ID, out var cdrArrangementId)) |
Check warning
Code scanning / SonarCloud
Use model binding instead of reading raw request data
| [Route("jwks/{id:int?}")] | ||
| [ServiceFilter(typeof(LogActionEntryAttribute))] | ||
| public async Task<IActionResult> GetJwks(int? id = 1) | ||
| public IActionResult GetJwks(int? id = 1) |
Check failure
Code scanning / SonarCloud
ModelState.IsValid should be called in controller actions
| [Route("jwks-with-private-keys/{id:int?}")] | ||
| [ServiceFilter(typeof(LogActionEntryAttribute))] | ||
| public async Task<IActionResult> GetJwksPrivateKeys(int? id = 1) | ||
| public IActionResult GetJwksPrivateKeys(int? id = 1) |
Check failure
Code scanning / SonarCloud
ModelState.IsValid should be called in controller actions
| ClientCertificates.Add(clientCertificate); | ||
| if (dhOptions.Ignore_Server_Certificate_Errors) | ||
| { | ||
| ServerCertificateCustomValidationCallback += (sender, cert, chain, sslPolicyErrors) => true; |
Check failure
Code scanning / SonarCloud
Server certificates should be verified during SSL/TLS connections
CDR-FarooqK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.

Checklist: (Put an
xin all the boxes that apply)developbranch has been set as thebasebranch to merge changes of the pull request.CHANGELOG.mdfile as appropriate.What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
v2.1.0 release
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: