Skip to content

Conversation

@CDR-AidenJ
Copy link
Contributor

Checklist: (Put an x in all the boxes that apply)

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that there aren't any other open Pull Requests from the same change.
  • The develop branch has been set as the base branch to merge changes of the pull request.
  • I have updated the CHANGELOG.md file as appropriate.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
v2.1.0 release

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

CDR-CI and others added 2 commits August 14, 2024 05:56
1. Update action steps to their latest versions.
2. Pass the build platform as a variable to target for the given platform
@CDR-AidenJ CDR-AidenJ requested a review from CDR-FarooqK August 19, 2024 03:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 19, 2024


if (dcrOptions.Ignore_Server_Certificate_Errors)
{
ServerCertificateCustomValidationCallback += (sender, cert, chain, sslPolicyErrors) => true;

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections

<!--SONAR_ISSUE_KEY:AZFotel5uttMHqCUx3E1-->Enable server certificate validation on this SSL/TLS connection <p>See more on <a href="https://sonarcloud.io/project/issues?id=ConsumerDataRight_mock-data-recipient&issues=AZFotel5uttMHqCUx3E1&open=AZFotel5uttMHqCUx3E1&pullRequest=79">SonarCloud</a></p>
{
// Get the cdr arrangement id from the http header.
if (!request.Headers.ContainsKey(HEADER_INJECT_CDR_ARRANGEMENT_ID))
if (!request.Headers.TryGetValue(HEADER_INJECT_CDR_ARRANGEMENT_ID, out var cdrArrangementId))

Check warning

Code scanning / SonarCloud

Use model binding instead of reading raw request data

<!--SONAR_ISSUE_KEY:AZFoteikuttMHqCUx3Ed-->Use model binding instead of accessing the raw request data <p>See more on <a href="https://sonarcloud.io/project/issues?id=ConsumerDataRight_mock-data-recipient&issues=AZFoteikuttMHqCUx3Ed&open=AZFoteikuttMHqCUx3Ed&pullRequest=79">SonarCloud</a></p>
[Route("jwks/{id:int?}")]
[ServiceFilter(typeof(LogActionEntryAttribute))]
public async Task<IActionResult> GetJwks(int? id = 1)
public IActionResult GetJwks(int? id = 1)

Check failure

Code scanning / SonarCloud

ModelState.IsValid should be called in controller actions

<!--SONAR_ISSUE_KEY:AZFotejWuttMHqCUx3Ef-->ModelState.IsValid should be checked in controller actions. <p>See more on <a href="https://sonarcloud.io/project/issues?id=ConsumerDataRight_mock-data-recipient&issues=AZFotejWuttMHqCUx3Ef&open=AZFotejWuttMHqCUx3Ef&pullRequest=79">SonarCloud</a></p>
[Route("jwks-with-private-keys/{id:int?}")]
[ServiceFilter(typeof(LogActionEntryAttribute))]
public async Task<IActionResult> GetJwksPrivateKeys(int? id = 1)
public IActionResult GetJwksPrivateKeys(int? id = 1)

Check failure

Code scanning / SonarCloud

ModelState.IsValid should be called in controller actions

<!--SONAR_ISSUE_KEY:AZFotejWuttMHqCUx3Ee-->ModelState.IsValid should be checked in controller actions. <p>See more on <a href="https://sonarcloud.io/project/issues?id=ConsumerDataRight_mock-data-recipient&issues=AZFotejWuttMHqCUx3Ee&open=AZFotejWuttMHqCUx3Ee&pullRequest=79">SonarCloud</a></p>
ClientCertificates.Add(clientCertificate);
if (dhOptions.Ignore_Server_Certificate_Errors)
{
ServerCertificateCustomValidationCallback += (sender, cert, chain, sslPolicyErrors) => true;

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections

<!--SONAR_ISSUE_KEY:AZFotek5uttMHqCUx3Eq-->Enable server certificate validation on this SSL/TLS connection <p>See more on <a href="https://sonarcloud.io/project/issues?id=ConsumerDataRight_mock-data-recipient&issues=AZFotek5uttMHqCUx3Eq&open=AZFotek5uttMHqCUx3Eq&pullRequest=79">SonarCloud</a></p>
Copy link
Contributor

@CDR-FarooqK CDR-FarooqK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@CDR-AidenJ CDR-AidenJ merged commit 7d91344 into develop Aug 19, 2024
@CDR-FarooqK CDR-FarooqK deleted the releases/2.1.0 branch August 22, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants