This repository was archived by the owner on Jul 29, 2022. It is now read-only.
Merge upstream master #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the spirit of CL 99955, fix all non-standard generated code headers and re-run the generators. Some generated files needed git gofmt afterwards, but that problem is left for now. Change-Id: I6b3131fb1753dc427d05af03107031120755cab0 Reviewed-on: https://go-review.googlesource.com/99975 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
The default ObjC prefix and Java package have been the empty string for a while, but the gomobile bind -help text wasn't updated. Change-Id: I8acb265ae7385121fae4c2cc314220d97575d20c Reviewed-on: https://go-review.googlesource.com/99317 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Updates golang/go#24185 Change-Id: I1ce066be52feff5d2372633776aa631e0ce7e713 Reviewed-on: https://go-review.googlesource.com/100684 Reviewed-by: Ian Lance Taylor <iant@golang.org>
The gobind command is about to get more powerful and able to generate complete and standalone bindings. Platform specific build tags based on GOOS or GOARCH are now meaningless to generate bindings from, so remove them from the test packages. The tags mattered to the reverse bound packages, since the go tool can't build them without the Go wrappers for the imported Java packages. Before this CL, the `android` tag was used to fool the go tool since the host GOOS is unlikely to be android. A fix is to check in the generated Go wrappers, but since the packages are for testing we don't want that. Instead, move the test packages to the testdata directory so the go tool ignores them. Change-Id: I57178e930a400f690ebd7a65758bed894eeb10b0 Reviewed-on: https://go-review.googlesource.com/99315 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
The gobind and gomobile bind tools have historically overlapped: gobind outputs generated bindings, and gomobile bind will generate bindings before building them. However, the gobind bindings were never used for building and thus allowed to not be complete. To simplify version control, debugging, instrumentation and build system flexibility, this CL upgrades the gobind tool to be the canonical binding generator and change gomobile bind to use gobind instead of its own generator code. This greatly simplifies gomobile bind, but also paves the way to skip gomobile bind entirely. For example: $ gobind -outdir=$GOPATH golang.org/x/mobile/example/bind/hello $ GOOS=android GOARCH=arm64 CC=<ndk-toolchain>/bin/clang go build -buildmode=c-shared -o libgobind.so gobind $ ls libgobind.* libgobind.h libgobind.so The same applies to iOS, although the go build command line is more involved. By skipping gomobile it is possible to freely customize the Android or iOS SDK level or any other flags not supported by gomobile bind. By checking in the generated source code, the cost of supporting gomobile in a custom build system is also decreased. Change-Id: I59c14a77d625ac1377c23b3213672e0d83a48c85 Reviewed-on: https://go-review.googlesource.com/99316 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Gobind now outputs Java sources to the java/ subdirectory. Update the gradle plugin to match. Only projects using reverse bindings are affected. Change-Id: Id7f893d3c67a9ab63336c4e031c9196a0b6dad2c Reviewed-on: https://go-review.googlesource.com/99775 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
The reverse bindings allow access to Java and ObjC APIs by importing Java/... and Objc/... package from Go. The gobind tool automatically create the bindings for the API referenced from the packages. The reverse example takes that ability too far, however. It creates a circular dependency from the Android databinding layout files to exported Go types while those same Go types access the Java classes generated by databinding. It works almost by accident, but not for newer Gradle versions. The circular dependencies are bad, but the underlying circular references created by using the reverse bindings this way are worse. I haven't found a satisfactory was to avoid retaining references to Go objects from Java and back without carefully and manually breaking cycles at appropriate times. One might succeed in ObjC where breaking reference cycles are already necessary, but not in Java. The reverse example is a nice technical feat, but promises more than it can deliver. Delete it. Fixes golang/go#19862 Fixes golang/go#18210 Change-Id: Ie6abd2a0ebd4c4ce36339d1294898e15f22f83bd Reviewed-on: https://go-review.googlesource.com/101155 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
If ever the gobind tool switches to a source importer (see CL 99777), make sure import paths are without trailing slashes are handled correctly. Change-Id: Ib3ce15f8dcd53dce09a5bb183e4013a5deba39b4 Reviewed-on: https://go-review.googlesource.com/99776 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
While we're here, sort the keyword list. Fixes golang/go#22875 Change-Id: I31844c3d66f959bb0dc47eb3062e41f75d7b765e Reviewed-on: https://go-review.googlesource.com/100795 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Fixes golang/go#21523 Change-Id: I1244e296ac4eeb0d10847e73216e4a25a3533292 Reviewed-on: https://go-review.googlesource.com/101115 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Fixes golang/go#21552 Change-Id: Id01434271916ddc489eb5f7d8355d9519885eaf4 Reviewed-on: https://go-review.googlesource.com/101116 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Fixes golang/go#18536 Change-Id: I82c5993547e4d1d0df14726ccc569e1f57128072 Reviewed-on: https://go-review.googlesource.com/101156 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Move the benchmark support package to the testdata directory, just like the other test packages. Change-Id: Idc35ca973a7da78e8c8bb640ba60cfb947fbed5b Reviewed-on: https://go-review.googlesource.com/101896 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gomobile checks "golang.org/x/mobile/..." packages are included in the build product using nm. If "golang/x/mobile/..." package is placed under vendor directory, this check fails and it is treated as a build failure. Fixes golang/go#22152 Change-Id: Ie0e05c3e0340b3608de5c68bb3f852d4ef7cdeb1 Reviewed-on: https://go-review.googlesource.com/102095 Reviewed-by: Elias Naur <elias.naur@gmail.com>
Issue golang/go#24058 demonstrates a Go package that fails to build with gomobile but builds successfully with a manually using the standalone NDK toolchain. I haven't been able to figure out a set of CPPFLAGS/LDFLAGS that fixes the build for 24058 so instead rework gomobile to use standalone NDK toolchains. Standalone toolchains fixes the 24058 build and is the official way to build Android programs. So gomobile should be less affected by future changes in the NDK toolchain internals. Create the standalone toolchains with gomobile init. With the new Go 1.10 build cache, the prebuild work by the gomobile init command is useless. Use the opportunity to simplify init to only creating NDK toolchains and, optionally, building OpenAL for Android. With that, it is no longer necessary to use gomobile init to build iOS apps and frameworks. Fixes golang/go#24058 Change-Id: I4692fcaa927e7076a6387d080ebc1726905afd72 Reviewed-on: https://go-review.googlesource.com/99875 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
When running gomobile bind, make sure gobind exists. If not, instruct the user to run gomobile init which will go install gobind. Change-Id: I2d064ba58874fd5581c17417124561f3d1fb6b83 Reviewed-on: https://go-review.googlesource.com/101055 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Instead of using os.Getenv("GOPATH"), use go env GOPATH to determine
the effective GOPATH.
Fixes golang/go#21658
Change-Id: I03f897969e30fc3256d171aa7b32c101a9342a1a
Reviewed-on: https://go-review.googlesource.com/101117
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Updates golang/go#20902 Change-Id: I523c0b7a205e620c143f2ba9c7cdbe30865a9c59 Reviewed-on: https://go-review.googlesource.com/101136 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
… name Now package names for Android is generated based on the given package path's base name, And the package name generation fails when the base name consists of only digits (e.g. github.com/hajimehoshi/ebiten/examples/2048). This CL fixes this problem by allowing only-number base name. Fixes #24511 Change-Id: I6108c46823d0b2ee08869b306922f62351fb1510 Reviewed-on: https://go-review.googlesource.com/102576 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Fixes golang/go#24571 Change-Id: I8d08548b4a4d6f9490a8bfd80c80a6408fde089b Reviewed-on: https://go-review.googlesource.com/102896 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
…build and bind While we're here, add 386 to the list of supported architectures on iOS. To support gomobile build for amd64 and 386, use the "ios" tag to distinguish between iOS and macOS builds. Change-Id: Ie09a432794bd8d9853950115349f8d3b57cf43f5 Reviewed-on: https://go-review.googlesource.com/102915 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Forgot to update tests on macOS after CL 102915. Change-Id: I902fd1046434d133129a0cd82bc28c3f7ee47816 Reviewed-on: https://go-review.googlesource.com/104455 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
For some reason, the changes to the build tags that was supposed to go in with CL 102915 didn't make it. Fixes golang/go#24644 Change-Id: I106b3c71fef1088dd1eea193323c13d81e5985fa Reviewed-on: https://go-review.googlesource.com/104355 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Delay loading of the getRune method ID to the first GoNativeActivity is created. That way, importing golang.org/x/mobile/app will not crash, even for gomobile bind programs that don't include (or use) GoNativeActivity. Fixes golang/go#24490 Change-Id: I4bf90e067700451f7c026e53165b6614366d7a94 Reviewed-on: https://go-review.googlesource.com/104395 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Bindings are independent of any particular GOOS/GOARCH pair and as such the gomobile bind command doesn't set GOOS nor GOARCH when running gobind. However, the ios tag was still added to the list of tags to pass to gobind for -target=ios. Move the ios tag to when actually building the bound packages, mirroring gomobile build. Add TestBindIOS and update TestBindAndroid. Updates golang/go#24644 Change-Id: I007829c26036427a3376bba11a1ccb86e7338848 Reviewed-on: https://go-review.googlesource.com/104458 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Before this change, binding unsupported basic types such as uint failed with an error. Instead, add them to the list of ignored types so that no error is generated and a comment is generated explaining why the offending function, constant or variable was skipped. Unsigned integers are probably easy to support in ObjC, but leave them unsupported for now. While here, improve the printing of the ignored types in the explaining comments. Fixes golang/go#24762 Change-Id: I0d9ab471b2245728270f6ee588f554d4a105d500 Reviewed-on: https://go-review.googlesource.com/105377 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Today, the Seq.Ref class has two purposes. For Java references, Ref contains the refnum, a reference to the Java object and a reference count. For Go references, Ref contains the refnum and its finalizer makes sure to decrement the reference count on the Go side. The next CL will replace the use of finalizers with an explicit ReferenceQueue of Go references, and the Ref class will no longer be used for Go refences. To prepare for that, this CL pulls up the construction of Go referencing Ref instances into the Seq.trackGoRef function. Change-Id: I9eefe238cd3fd1b661b2af11d331a2f61e31303b Reviewed-on: https://go-review.googlesource.com/106875 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Android runs a finalizer watchdog that tracks the running time of finalizers and throws an exception if any runs too long. Our finalizers do very little work and as such are not affected by the timeout. However, there has been reports, for example: https://stackoverflow.com/questions/24021609/how-to-handle-java-util-concurrent-timeoutexception-android-os-binderproxy-fin that the watchdog does not take into account periods where the device goes to sleep in the middle of a finalizer run. So if a given app runs in the background, the Java GC starts a finalizer and the device goes to sleep before it returns, an exception will crash the app if the sleep period extends the watchdog timeout. The problem might be fixed on some newer version of Android, but the problem is reported for as late as Android 6. The suggested workaround is to use PhantomReferences and run a background thread that take dead references off a ReferenceQueue and perform cleanup. This CL builds on the previous CL and splits up the Ref class so Refs only reference counts Java objects, while a new class GoRef tracks Go references. The Go references are wrapped in PhantomReferences that in turn appear on a GoRefQueue to be cleaned up by a background (daemon) Thread. Change-Id: I04e3296b851999c612d3baf6a593cc044c2c5bdd Reviewed-on: https://go-review.googlesource.com/106876 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
When passing a refnum across the language barrier there is a small window where a proxy object itself can be garbage collected, its reference count go to 0 and the object be gone when the refnum is dereferenced on the other side. In Go the proxy object is pinned with runtime.KeepAlive. This CL implements the same mechanism in Java by passing the proxy object to native code, ensuring the Java GC can't reclaim it during the call. Change-Id: I23824439012eb00f90d729f59d4846999f24f01f Reviewed-on: https://go-review.googlesource.com/107095 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
CL 99316 changed gobind to be platform independent, so
standalone bindings could be generated without having the
Android and Xcode SDKs installed. However, bindings that does
depend on GOOS for its exported API, in particular go source
files that use Cgo now only works if the exported API is
extracted to platform independent files.
By switching to use the source importer, importer.For("source", nil),
gobind can type check the bound packages even in the presence of
Cgo.
The source importer in Go 1.9 and 1.10 has problems with relative
imports and imports from testdata directories (issues 23092 and 24392),
but works from Go 1.10.1 on.
Fixes golang/go#24856
Change-Id: Icb18dce15325b7d4e58cabc1181051bc6269fc1f
Reviewed-on: https://go-review.googlesource.com/99777
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Ia4925c83dad0a905dc8b74b8494a0d750fbe18be Reviewed-on: https://go-review.googlesource.com/c/mobile/+/569055 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Than McIntosh <thanm@google.com>
Change-Id: Ifdadb14d311a3620e499f0b33feefa3e0448a6f1 GitHub-Last-Rev: 4c346f5 GitHub-Pull-Request: #97 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/573035 Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Hajime Hoshi <hajimehoshi@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
…orm, fixing Xcode 15.3 compatibility issues This patch updates the framework generation code to follow the Apple spec for placing content: https://developer.apple.com/documentation/bundleresources/placing_content_in_a_bundle Previously, we setup the framework in MacOS format, and used symlinks to make it compatible with iOS format. This approach no longer works (it works locally in simulator, but causes signing issues when attempting to upload apps for distribution, or running on real hardware). We now setup the expected bundle format for each platform. Other benefits: - Thirds the size of the xcframework and resulting app binary when distributing the xcframework by zip (common for SPM and other formats). The symlinks resulted in duplicate files after zipping, which made it into the final app. - Set MinimumOSVersion, fixing SPM compatibility issue - Eliminates the blank Info.plist - Initial testing shows this also fixes golang/go#66406 (code signing issues) as a side effect of using the proper format Testing: - Tested all 4 platforms (iOS, simulator, macOS, Catalyst) on Xcode 15.3 Fixes golang/go#66406 Fixes golang/go#66500 Change-Id: I8538989efe67cb0d2d0496087dcbeca923c3dffe GitHub-Last-Rev: 28dca85 GitHub-Pull-Request: #98 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/574055 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
…ing Apple validation/distribution An app containing a framework can't be validated and distributed without these two entries in the framework bundle's `Info.plist`. Using `0.0.epoch` format per discussion here: https://go.dev/issue/66500#issuecomment-2025767017 Tested Xcode 15.3 with: - without keys, fails to validate - with keys: passing validation, distribution upload, and Apple's server validation ("Ready to test" server check). Fixes golang/go#66500 Change-Id: I2e0718247301ec7db36f8d85aea81b203ca7848b GitHub-Last-Rev: 1455c5e GitHub-Pull-Request: #100 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/575115 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com> Reviewed-by: Than McIntosh <thanm@google.com>
Change-Id: I94b7d1c7029102c252a77f75929066281040b9f2 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/564856 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Ie35799c1d449abe67ebd57c89c0d586eae5cfc02 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/576638 Auto-Submit: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I573cd0cd9833927ef61b0c23fe30dc9140dd5696 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/583595 Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Than McIntosh <thanm@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
ALooper_pollAll is no longer available as of Android SDK 34. Fixes golang/go#67496 Change-Id: I1f781ef70d569df50d3059ce355a2f7d1edb435a Reviewed-on: https://go-review.googlesource.com/c/mobile/+/586595 Run-TryBot: Hajime Hoshi <hajimehoshi@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Auto-Submit: Hajime Hoshi <hajimehoshi@gmail.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I8374c5df7d1cade76e1898b1d6377edd8c26537a Reviewed-on: https://go-review.googlesource.com/c/mobile/+/590455 Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I86ba44822d818d83ac6f24d3456b12a37a974dda Reviewed-on: https://go-review.googlesource.com/c/mobile/+/596996 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@google.com> Auto-Submit: Gopher Robot <gobot@golang.org>
Very minor tweaks: - Remove (c) pseudosymbol. - Remove "All Rights Reserved." - Change "Google Inc." (no longer exists) to "Google LLC". [git-generate] echo ' ,s/\(c\) // ,s/ All rights reserved.// ,s/Google Inc./Google LLC/ w q ' | sam -d LICENSE Change-Id: Ib9d60f53433c8e92a0968c2b6d920876b5f7e7e9 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/598523 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Russ Cox <rsc@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Id31b88c1c74c05ce63204c3a833ef554ec296112 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/603616 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: David Chase <drchase@google.com>
There's some similarity here to the situation in CL 610676. The calls
that now look like g.Printf("%s", something) would perhaps be better
expressed like g.Print(something) or g.WriteString(something), but
that's a bigger potential change to consider. This is a minimal fix.
For golang/go#69267.
Change-Id: I9cf23aef7bf2b9d9c7e9dcf3b48ecb23231016dd
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/610800
Reviewed-by: Tim King <taking@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I47a97af459b0151af8af9df1bed5ee25312579a9 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/611936 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: David Chase <drchase@google.com> TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Gopher Robot <gobot@golang.org>
The iOS implementation was just copied from the desktop version, and had and extra directory 'assets'. Also, files had an incorrect assumption that Arm Darwin should be an iOS. This change addresses these issues. Fixes golang/go#37177 Change-Id: I8e4de5337fbbe0b7697a8d519c8bded783399244 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/616655 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Ieee46df13d96ef0bc2be98e40f38f58c73131bcc Reviewed-on: https://go-review.googlesource.com/c/mobile/+/617960 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com>
It dosen't make sense to parse stdout and stderr to get a necessary information like clang command. Actually envClang sometimes didn't work correctly due to this. Fixes golang/go#53316 Change-Id: Ia2c518c44c0003b4f9b50dba85fb971c2ef4340d Reviewed-on: https://go-review.googlesource.com/c/mobile/+/620315 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com>
Change-Id: Id01077e4708b481e42b5aab6a34c25d6e34d1fe0 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/625397 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Commit-Queue: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
In modern versions of the go command, the go mod tidy command doesn't consider module requirements coming from files with an "ignore" build constraint. Use "tools" instead. This way, running go mod tidy on this module becomes a no-op, instead of deleting all of the requirements from go.mod and go.sum. Change-Id: I42a24c462acf7340410614fa3b0dd80608efcdaa Reviewed-on: https://go-review.googlesource.com/c/mobile/+/626655 Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I088f0acac42498a4148da7e98ace3a823be94ffe Reviewed-on: https://go-review.googlesource.com/c/mobile/+/626595 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Ia4e7f4bf74f5d06295bd5fccd8542940796022ee Reviewed-on: https://go-review.googlesource.com/c/mobile/+/633588 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: David Chase <drchase@google.com>
The problem was observed after Go 1.18. x/mobile requires go1.22.0+. Patch from stffabi@e31230f For golang/go#52299 Co-authored-by: stffabi <stffabi@users.noreply.github.com> Change-Id: I856c68f60ad7c45acf4ae550a1e66747ef7719db Reviewed-on: https://go-review.googlesource.com/c/mobile/+/635342 Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
Change-Id: I26f303201caebbe159f2e79f577e8d05b325c6ee Reviewed-on: https://go-review.googlesource.com/c/mobile/+/639615 Reviewed-by: Jorropo <jorropo.pgm@gmail.com> Auto-Submit: Jorropo <jorropo.pgm@gmail.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Idf8f21610ad2aa7b52f54849dcc920a1990c6407 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/640697 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I4ec34da0a0903d47fc2b25a116fef256d63f8f1f Reviewed-on: https://go-review.googlesource.com/c/mobile/+/648176 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Bind currently targets the earlier go/types semantics (gotypesalias=0), and needs to be updated to be compatible with the new (gotypesalias=1). This is the only way in which the module isn't compatible with Go 1.23 language semantics, so add an explicit godebug line for it with a TODO. This unblocks moving the module to Go 1.23 (as done in the next CL). For golang/go#70698. Change-Id: I59a61defdcf327aed9ccd67b123b1516cd118d9e Reviewed-on: https://go-review.googlesource.com/c/mobile/+/649381 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com>
By now Go 1.24.0 has been released, and Go 1.22 is no longer supported per the Go Release Policy (https://go.dev/doc/devel/release#policy). For golang/go#69095. [git-generate] (cd example/ivy && go get go@1.23.0 && go mod tidy && go fix ./... && go mod edit -toolchain=none) (cd . && go get go@1.23.0 && go mod tidy && go fix ./... && go mod edit -toolchain=none) Change-Id: Icc4624c0ff649e040bef1b068e92b43fdb57c72e Reviewed-on: https://go-review.googlesource.com/c/mobile/+/649378 Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
The standard copyright header at https://go.dev/doc/contribute#copyright has a single space (also see CL 20022). Also, add it to a files where it was missed. Change-Id: I341ce5b5c455efa768b65597c387866e47a6757e Reviewed-on: https://go-review.googlesource.com/c/mobile/+/649382 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Import comments were initially used to specify the canonical import path of a package, to prevent it from being used with a non-canonical path by accident. The module path in the go.mod file serves that purpose now. Change-Id: I36ebca191eb996b7254a6d452aa4f8dba88a6f94 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/649383 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I38d44c7d8e64e31452841c3901aad7a7604c6936 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/655042 Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Gopher Robot <gobot@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.