Skip to content

Conversation

@Mudaafi
Copy link
Contributor

@Mudaafi Mudaafi commented Aug 29, 2024

Pull Request Checklist

Before you submit a pull request, please make sure you have to following:

  • I have added or updated TypeScript types for my changes, ensuring they are compatible with the existing codebase.
  • I have added JSDoc comments to my TypeScript definitions for improved documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added any necessary documentation (if appropriate).
  • I have made sure my PR is up-to-date with the main branch.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Documentation content changes
  • TypeScript type definitions update
  • Other: GitHub Action for Deploying Storybook

@Mudaafi Mudaafi added the wip Edits in Progress label Aug 29, 2024
@Mudaafi Mudaafi requested a review from a team as a code owner August 29, 2024 23:42
@linear
Copy link

linear bot commented Aug 29, 2024

CI-3838 GHA - Deploy Storybook

  • Create an action to deploy documentation
  • Delete the docs folder on github (we don't need that anymore)

@Mudaafi
Copy link
Contributor Author

Mudaafi commented Aug 29, 2024

Looks like there's branch protection on both

  • workflow_dispatch meaning we can't run the action manually and,
  • the environment github-pages which by default only allows itself on the default branch aka main

@Mudaafi Mudaafi removed the wip Edits in Progress label Aug 30, 2024
@@ -0,0 +1,323 @@
import React from 'react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sneaking this file into this big PR hoping no one would notice? Or is this a mistake and shouldn't be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D: thank you for catching that good sir, I will remove that file immediately

Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one comment

@Mudaafi Mudaafi merged commit 130a74a into main Aug 30, 2024
@Mudaafi Mudaafi deleted the ci-3838-gha-deploy-storybook branch August 30, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants