Skip to content

Conversation

@Mudaafi
Copy link
Contributor

@Mudaafi Mudaafi commented Aug 29, 2024

Notes

We had a prior discussion in RFC #16 on where the types should live but it's a little stale since components were not meant to be available to the consumer. Since we are now exporting them, I've opted to leave the majority of them where they are, and adjusted the Pagination component to follow.

I've also tested this on a sandbox react app and the types can be imported seamlessly.

Pull Request Checklist

Before you submit a pull request, please make sure you have to following:

  • I have added or updated TypeScript types for my changes, ensuring they are compatible with the existing codebase.
  • I have added JSDoc comments to my TypeScript definitions for improved documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added any necessary documentation (if appropriate).
  • I have made sure my PR is up-to-date with the main branch.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Documentation content changes
  • TypeScript type definitions update
  • Other: This PR exposes components that can be used by the Library Consumer

@Mudaafi Mudaafi requested a review from a team as a code owner August 29, 2024 22:51
@linear
Copy link

linear bot commented Aug 29, 2024

CI-3812 Expose Components

We're working on a parallel initiative that requires components to be imported individually

@Mudaafi Mudaafi merged commit 68dc50f into main Aug 30, 2024
@Mudaafi Mudaafi deleted the ci-3812-expose-components branch August 30, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants