CI-3648 Responsiveness Improvements #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI-3648 MVP [OS UI PLP]: Mobile Friendly Styles for Filters
Business Outcome:
Definition of done:
|
…-mobile-friendly-styles-for-filters
Mudaafi
requested changes
Aug 22, 2024
Contributor
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
Looking good! I left some comments, but the one on using timeout for css transitions, let's discuss in our sync later today
| // Calculate windowSize on resize event | ||
| useEffect(() => { | ||
| const resize = () => { | ||
| const parentSize = Number(pagesRef.current?.parentElement?.clientWidth) || window.innerWidth; |
Contributor
There was a problem hiding this comment.
Just so I'm clear, we're checking for the parentElement's width first if it exists, else we go with the window?
Contributor
Author
There was a problem hiding this comment.
yes, this is mainly for edge cases (domless scenarios like jest testing)
Contributor
There was a problem hiding this comment.
no I think this is a good default. Most times, customers will use a container to host both the entire PLP, so setting the width to the container first is better
…-mobile-friendly-styles-for-filters
Mudaafi
approved these changes
Aug 24, 2024
Mudaafi
deleted the
ci-3648-mvp-os-ui-plp-mobile-friendly-styles-for-filters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Before you submit a pull request, please make sure you have to following:
PR Type
What kind of change does this PR introduce?
Changes for mobile view
split header and 2-column grid
filters and sort options as modals
pagination resize with window
