Skip to content

Conversation

@Mudaafi
Copy link
Contributor

@Mudaafi Mudaafi commented Apr 23, 2024

Pull Request Checklist

Before you submit a pull request, please make sure you have to following:

  • NA I have added or updated TypeScript types for my changes, ensuring they are compatible with the existing codebase.
  • NA I have added JSDoc comments to my TypeScript definitions for improved documentation.
  • NA I have added tests that prove my fix is effective or that my feature works.
  • NA I have added any necessary documentation (if appropriate).
  • I have made sure my PR is up-to-date with the main branch.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Documentation content changes
  • TypeScript type definitions update
  • Other... Please describe:
  1. Adds the global stylesheet to every story
  2. Adds a top-level css class to assign font-family to every component (we do this in quizzes-ui)
  3. Remove unused Button component that was just lying there

TODO [Pre-launch]

  1. Standardize file structure
    • Pagination
    • index.css/ts (Barrel File naming structure See RFC 21)
  2. Remove css imports within each component. (Research story CI-3425)

@linear
Copy link

linear bot commented Apr 23, 2024

CI-3432 [MVP] PLP OS UI: InterFont

We use the Inter font in quizzes. We should use it here too

@Mudaafi Mudaafi requested a review from a team April 23, 2024 18:23

return <CioPlpProvider {...props}>{children || defaultMarkup}</CioPlpProvider>;
return (
<div className='cio-plp-global'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need global here? Not a big deal I just wanted to check if we can make it consistent across repos. I think we have cio-quiz and cio-autocomplete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like consistency

Copy link
Contributor

@esezen esezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one small comment. Feel free to merge with or without it

@Mudaafi Mudaafi merged commit 09bdf31 into main Apr 26, 2024
@Mudaafi Mudaafi deleted the ci-3432-mvp-plp-os-ui-interfont branch April 26, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants