-
Notifications
You must be signed in to change notification settings - Fork 2
[CI 3213] Create zero results page #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI-3213 [MVP] Create Zero Results Page
Business Outcome:
Definition of done:
Additional notes |
Mudaafi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's a simple component but could we make it into it's own separate component file? We'll need to reuse it for Browse in the future so I think it makes sense to have it separately.
On a separate note, could we also add another story under SearchResults? This would be specifically for zero results. We'll want to track changes to it via chromatic. Something like this should work:
export const ZeroResults: Story = {
render: (args) => (
<CioPlp apiKey={DEMO_API_KEY}>
<div>Example Url: https://www.example.com?q=cvwdacoknqeauosd1</div>
<br />
<SearchResults {...args} />
</CioPlp>
),
decorators: [
(Story) => {
const url = new URL(window.location as any);
// eslint-disable-next-line @cspell/spellchecker
url.searchParams.set('q', 'cvwdacoknqeauosd1');
window.history.pushState({}, '', url);
return <Story />;
},
],
};
|
I also added the font-change story CI-3432 👍 I can take it later today |
done. It's failing the spellcheck check even with the eslint line but hopefully that's not an issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! We'll probably want to replace
// eslint-disable-next-line @cspell/spellchecker
with
/* cspell:disable-next-line */
That'll probably fix the failing spellcheck
TODO (in future PR): Make the fonts look nicer