Skip to content

Conversation

@HHHindawy
Copy link
Contributor

No description provided.

@HHHindawy HHHindawy requested a review from a team March 4, 2024 22:21
@linear
Copy link

linear bot commented Mar 4, 2024

CSL-3158 [MVP] Create a useSortOrder Hook

A React Hook to be used within the PLP Context, either;

  • Internally, within the SortOrder Component
  • Externally, by consumers intending to use the hooks

Definition of done:

  • This hook should exist within the context of the PlpContext
  • Tests
  • Documentation

Copy link
Contributor

@stanlp1 stanlp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look. Looked mostly good to me. hard to review without a component to test 😅

I just had some small questions

@HHHindawy HHHindawy requested review from Mudaafi and stanlp1 March 13, 2024 13:35
Copy link
Contributor

@stanlp1 stanlp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Copy link
Contributor

@Mudaafi Mudaafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HHHindawy HHHindawy merged commit 64b0fdd into main Mar 13, 2024
@HHHindawy HHHindawy deleted the csl-3158-mvp-create-a-usesortorder-hook branch March 13, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants