Fix: update getUrl type

[Mudaafi]

Updating the types here to match our new, server-side compatible, getUrl implementation

[mocca102]

If it's optional, let's add a question mark instead; what do you think?

[Mudaafi]

It's not that it's optional, but rather that the function can return undefined on server-side. I can modify it to return null instead if that makes more sense. See this PR

[mocca102]

Challenge me on this, please if you think otherwise. But I like to reserve undefined for values that haven't been passed or haven't had any operations.

[Mudaafi]

Fair enough, I was thinking along the lines of either

• A function that doesn't have a return value
• On the server --> may as well have not run getUrl --> Effectively no operations --> undefined

but I'm not too picky about it. I guess a better way to decide is what should getUrl return on the server if it's not supposed to run? In code:

getUrl() {
  if (typeof window === 'undefined') {
    // Option 1
    return; // undefined

    // Option 2
    return null; // explicitly null
...
  }
}

[mocca102]

Actually after you laying out like this, not sure anymore 😅

[mocca102]

LGTM!