Skip to content

[CSL-2813] Configure pre-push hook #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

[CSL-2813] Configure pre-push hook #5

merged 1 commit into from
Oct 3, 2023

Conversation

@esezen
Copy link
Contributor

@esezen esezen commented Sep 30, 2023

@linear
Copy link

linear bot commented Sep 30, 2023

CSL-2813 [MVP] Update Husky

Business Outcome:

  • As a Engineer I want useful development tools so that I can be productive

Definition of Done

  • Update Husky to not do pre-commit hooks
  • Make sure we have good pre-push hooks similar to client-js

"We don’t have husky in Quizzes. I don’t have any arguments against it but I think we shouldn’t have any pre-commit hooks. They make life harder. IMHO, it’s better to have pre-push like we do in client-js" - Mr Enes, Engineering Genius

@esezen esezen requested a review from a team September 30, 2023 13:14
jjl014
jjl014 approved these changes Oct 3, 2023
View reviewed changes
Copy link

@jjl014 jjl014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@esezen esezen merged commit 883e7d9 into main Oct 3, 2023
@esezen esezen deleted the csl-2813-mvp-update-husky branch October 3, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjl014 jjl014 jjl014 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@esezen @jjl014