[CSL-3123] Pagination component and hook SSR tests #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSL-3123 [OS UI PLP] React Serve Tests - Pagination
Business Outcome:
Definition of done:
|
HHHindawy
changed the title
mocca102
reviewed
Jan 29, 2024
| }) => { | ||
| const [totalPages, setTotalPages] = useState(0); | ||
| const [currentPage, setCurrentPage] = useState<number>(); | ||
| const [currentPage, setCurrentPage] = useState<number | undefined>(initialPage); |
Contributor
There was a problem hiding this comment.
Since we're passing initialPage here I think we need to remove this useEffect right?
useEffect(() => {
if (initialPage) {
setCurrentPage(initialPage);
}
}, [initialPage]);
mocca102
reviewed
Jan 29, 2024
| const { result } = renderHookServerSide(() => usePagination(paginationProps), {}); | ||
| expect(result.totalPages).toBe(0); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
let's test that pages returned from usePagination is an empty array
mocca102
reviewed
Jan 29, 2024
spec/usePagination.server.test.js
Outdated
| windowSize: 10, | ||
| }; | ||
|
|
||
| describe('usePagination', () => { |
Contributor
There was a problem hiding this comment.
This is just so we're consistent with the other tests for the server tests we describe it like "Testing Hook on the server: usePagination"
mocca102
requested changes
Jan 29, 2024
Contributor
mocca102
left a comment
mocca102
left a comment
There was a problem hiding this comment.
Left small comments. But looking good overall
mocca102
approved these changes
Feb 5, 2024
Contributor
mocca102
left a comment
mocca102
left a comment
There was a problem hiding this comment.
Thanks for making the changes! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.