Rename CioPlpContext to CioPlp #42
Conversation
CSL-2888 [MVP] - PLP Grid Component
Business Outcome:
Definition of done:
Additional Notes:
|
| @@ -0,0 +1,56 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
No changes here just moved the file into CioPlp
| expect(html).toContain('<div>Test</div>'); | ||
| }); | ||
|
|
||
| it('renders CioPlp provider with render props on the server', () => { |
There was a problem hiding this comment.
The only new test case for renderProps pattern
| @@ -0,0 +1,59 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Add tests for client side
src/components/CioPlp/index.tsx
Outdated
| @@ -1,13 +1,52 @@ | |||
| import React from 'react'; | |||
| import { useCioPlpContext } from '../../PlpContext'; | |||
| import React, { useMemo, useState } from 'react'; | |||
There was a problem hiding this comment.
This is previously CioPlpContext
src/components/CioPlp/index.tsx
Outdated
| <div>{JSON.stringify(state?.cioClientOptions)}</div> | ||
| </div> | ||
| <PlpContext.Provider value={contextValue}> | ||
| {typeof children === 'function' ? children(contextValue) : children} |
There was a problem hiding this comment.
The provider accepts direct children or children function for renderProps pattern support
| @@ -0,0 +1,13 @@ | |||
| import { createContext, useContext } from 'react'; | |||
There was a problem hiding this comment.
Moved useCioPlpContext into a hooks file
No new code here
| */ | ||
| export type IncludeRenderProps<P, RenderProps> = P & { | ||
| children?: (props: RenderProps) => ReactNode; | ||
| export type IncludeRenderProps<ComponentProps, ChildrenFunctionProps> = ComponentProps & { |
There was a problem hiding this comment.
IncludeRenderProps should accept both a children function {() => ()} or children components <ChildComponent />
| @@ -1,5 +1,4 @@ | |||
| #storybook-root { | |||
| display: flex; | |||
There was a problem hiding this comment.
This was breaking the hooks examples
Most of the changes are just renaming CioPlpContext -> CioPlp. The actual code changes are small