[CDX-279] Add Deprecation Notice to PaginationConfigs resultsPerPage and totalNumResults
#185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The top-level pagination configs and only affects the rendering of the pagination component and not the actual request made to Constructor. This leads to confusion when attempting to adjust the number of results per page, especially since there isn't an instance where we'd want these values to be different from what is returned in the response (See CioPlpGrid.tsx)
However, since this might be breaking for any consumers using the configs, we'll put up a deprecation notice first and deprecate it in a future major version.
Pull Request Checklist
Before you submit a pull request, please make sure you have to following:
PR Type
What kind of change does this PR introduce?