[CDX-190] Feature: Add a function to clear all filters #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mudaafi
approved these changes
Sep 9, 2025
Contributor
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
lgtm, just a couple of notes
| current: { setFilter, clearFilters }, | ||
| } = result; | ||
|
|
||
| setFilter('Brand', testBrandA); |
Contributor
There was a problem hiding this comment.
Let's include more than one filter for this test. Mind adding a separate test to make sure it doesn't clear other query parameters, Constructor or otherwise, as well?
Contributor
Author
There was a problem hiding this comment.
Hi @Mudaafi
Thank you for the feedback.
I have added a test that uses useRequestConfigs to check for other query parameters
For your review please!
Thank you!
Mudaafi
approved these changes
Sep 10, 2025
evanyan13
deleted the
cdx-190-plp-ui-feature-add-a-function-to-clear-all-filters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
PR Type
Definition of Done
useFilters