[CI-4406] Bugfix: Range filters not correctly rendering if a range filter has already been applied #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…track length if facets.min > 0
Mudaafi
commented
Apr 30, 2025
Comment on lines
+121
to
+122
|
|
||
| setIsModified(true); |
Contributor
Author
There was a problem hiding this comment.
This prevents the initial useEffect function from rerendering to the default values
Mudaafi
commented
Apr 30, 2025
Comment on lines
+141
to
+144
| const trackLen = facet.max - facet.min; | ||
| const rebasedStartValue = minValue - facet.min; | ||
| const startPercentage = ((100 * rebasedStartValue) / trackLen).toFixed(2); | ||
| const widthPercentage = ((100 * (maxValue - minValue)) / trackLen).toFixed(2); |
Contributor
Author
There was a problem hiding this comment.
Rebases the track length to account for non-zero facet.min values
esezen
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Before you submit a pull request, please make sure you have to following:
PR Type
What kind of change does this PR introduce?