[CI-4303] Update Code Example - CioPlp #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanyan13
changed the title
evanyan13
changed the title
mocca102
reviewed
Apr 21, 2025
Contributor
mocca102
left a comment
mocca102
left a comment
There was a problem hiding this comment.
I liked when you added instructions for how to view the example and see the component in action in CioPlp? Can we do something similar here? Maybe an example with search or browse @evanyan13
To view the examples and see this component in action, append your URL with /group_id/1035, as this corresponds to a Browse Page.
Mudaafi
approved these changes
Apr 30, 2025
Contributor
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
Let's remove types from the code examples. It's best if it works OOTB in a js env. We already have the type definition in the earlier table, but we can also include it in the individual code examples descriptions. E.g.
> #### `getUrl`
- Default Implementation
- setUrl -> (newEncodedUrlState: string) => void
```javascript
....
Mudaafi
approved these changes
May 1, 2025
Contributor
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
lgtm, thanks for making the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CioPlpcomponent