[CI-4327] Add cnstrc data attributes to Product Card #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocca102
reviewed
Apr 11, 2025
src/utils.tsx
Outdated
| return 'unknown'; | ||
| } | ||
|
|
||
| export function getProductCardCnstrcDataAttributes(item: Item, productInfo: ProductInfoObject) { |
Contributor
There was a problem hiding this comment.
Can we consolidate both parameters into one object instead
Contributor
Author
There was a problem hiding this comment.
I added itemId as a return to productInfo instead. I feel like it makes sense to return it there too.
Mudaafi
requested changes
Apr 17, 2025
Contributor
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
Would it make sense to write a simple test for getProductCardCnstrcDataAttributes as well? It's reliant on the type ProductInfoObject, so it'd be nice to know this method stops working if we change that type in the future but our check-types might catch it regardless.
stanlp1
force-pushed
the
ci-4327-os-plp-ui-expose-data-attributes-on-product-card
branch
from
d8e9aaa to
7fb5139
Compare
Mudaafi
approved these changes
Apr 17, 2025
Contributor
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
lgtm, thanks for making the changes
Mudaafi
deleted the
ci-4327-os-plp-ui-expose-data-attributes-on-product-card
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Before you submit a pull request, please make sure you have to following:
PR Type
What kind of change does this PR introduce?