[CI-4339] Fix Sort Component Rendering to Inputs with the Same Id #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Description
Fixes a bug where two inputs were rendered with the same id for Sort Options. While the Desktop sort options are set to
display: none, we are still rendering the elements to the DOM. This leads to weird behaviors on mobile due to invalid DOM structure.To fix this, rather than attempting to use JavaScript to determine when the css screen breakpoints are reached, we keep the existing behavior, but just render the inputs with different ids.
Pull Request Checklist
Before you submit a pull request, please make sure you have to following:
PR Type
What kind of change does this PR introduce?