Skip to content

Conversation

@evanyan13
Copy link
Contributor

  • Moved src/utils.tsx to src/utils folder and split it into two separate files
    • utilFunctions
    • pageHelpers
  • Created src/utils/index.ts to export all functions within folder
  • Exported entire utils folder in src/index.ts
export * as utils from './utils';

@evanyan13 evanyan13 requested a review from Mudaafi April 3, 2025 20:52
@evanyan13 evanyan13 self-assigned this Apr 3, 2025
@evanyan13 evanyan13 requested a review from a team as a code owner April 3, 2025 20:52
Copy link
Contributor

@Mudaafi Mudaafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This change should be backwards compatible as the functions that were previously available in utils from import {utils} from plp-library will continue to be available alongside these other functions. The only issue would be if they directly referenced certain paths in the utils folder to gain access to MakeOptional, they would now get a reference error after updating. I think explicitly navigating down the library tree when importing the library isn't something we need to ensure backwards support for, so I believe we're good 👍

@evanyan13 evanyan13 merged commit dc1bfb7 into main Apr 10, 2025
10 of 11 checks passed
@evanyan13 evanyan13 deleted the ci-4335-plp-ui-exported-by-all-utils-functions branch April 10, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants