]CSL-2874] A/b test search suggestion variants

[stanlp1]

No description provided.

[mocca102]

I think this need to be part of the hooks logic and we only expose the features as a state returned form the hooks instead of exposing the utility function for consumers of the library to use it to get the features. And we do call getSearchSuggestionFeatures internally instead and expose smth like this in the hook response

featureToggles: {
    featureDisplaySearchSuggestionImages,
    featureDisplaySearchSuggestionResultCounts,
  }

@esezen what do you think?

[esezen]

I think this makes sense. @stanlp1 anything against this approach?

[stanlp1]

Nope, Islam mentioned this to me, I suggested tagging you as the decision maker 😂

[mocca102]

Thanks for making the changes! This is looking pretty good

Just left small comments and lets get a second eye

[mocca102]

Thanks for making the changes @stanlp1 🚀

[esezen]

LGTM!

[esezen]

@stanlp1 I thought tests are failing on main at first but they seem to be passing there. Would you be able to check why they are failing here?

[stanlp1]

@stanlp1 I thought tests are failing on main at first but they seem to be passing there. Would you be able to check why they are failing here?

Looks like the changes I made to resolve the failing tests 3 weeks ago don't work anymore. Reverted 👍